Issue 5183 - Provide async interface for FileSystem

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 109 matching lines @@
   const JsContext context(*jsEngine);
   return UnwrapValue()->IsFunction();
 }
 
 std::string AdblockPlus::JsValue::AsString() const
 {
   const JsContext context(*jsEngine);
   return Utils::FromV8String(UnwrapValue());
 }
 
-std::vector<char> AdblockPlus::JsValue::AsBuffer() const

[sergei, 2017/07/06 14:14:05]

Since there is a buffer type in JS, what about calling the methods slightly
differently to avoid confusion, e.g. `GetStringBuffer` and `SetStringProperty`?

[hub, 2017/07/06 14:33:31]

I'm ok with AsStringBuffer() like we have AsString().

-{
-  const JsContext context(*jsEngine);
-  return Utils::BufferFromV8String(UnwrapValue());
+StringBuffer AdblockPlus::JsValue::AsStringBuffer() const
+{
+  const JsContext context(*jsEngine);
+  return Utils::StringBufferFromV8String(UnwrapValue());
 }
 
 int64_t AdblockPlus::JsValue::AsInt() const
 {
   const JsContext context(*jsEngine);
   return UnwrapValue()->IntegerValue();
 }
 
 bool AdblockPlus::JsValue::AsBool() const
 {
@@ skipping 58 matching lines @@
 {
   return v8::Local<v8::Value>::New(jsEngine->GetIsolate(), *value);
 }
 
 void AdblockPlus::JsValue::SetProperty(const std::string& name, const std::string& val)
 {
   const JsContext context(*jsEngine);
   SetProperty(name, Utils::ToV8String(jsEngine->GetIsolate(), val));
 }
 
-void AdblockPlus::JsValue::SetProperty(const std::string& name, const std::vector<char>& val)

[hub, 2017/07/06 14:33:32]

I'll rename it to SetStringProperty then.

[sergei, 2017/07/07 13:29:27]

Could you please rename it?

[hub, 2017/07/07 13:39:20]

Sorry, I had the change shelved by mistake. Current patch has it.

-{
-  const JsContext context(*jsEngine);
-  SetProperty(name, Utils::ToV8String(jsEngine->GetIsolate(), val));
+void AdblockPlus::JsValue::SetStringBufferProperty(const std::string& name, const StringBuffer& val)
+{
+  const JsContext context(*jsEngine);
+  SetProperty(name, Utils::StringBufferToV8String(jsEngine->GetIsolate(), val));
 }
 
 void AdblockPlus::JsValue::SetProperty(const std::string& name, int64_t val)
 {
   const JsContext context(*jsEngine);
   SetProperty(name, v8::Number::New(jsEngine->GetIsolate(), val));
 }
 
 void AdblockPlus::JsValue::SetProperty(const std::string& name, const JsValue& val)
 {
@@ skipping 61 matching lines @@
   const v8::TryCatch tryCatch;
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   v8::Local<v8::Value> result = func->Call(thisObj, args.size(),
     args.size() ? &args[0] : nullptr);
 
   if (tryCatch.HasCaught())
     throw JsError(tryCatch.Exception(), tryCatch.Message());
 
   return JsValue(jsEngine, result);
 }