Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/FilterEngine.cpp

Issue 29449592: Issue 5183 - Provide async interface for FileSystem (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Rebased. Corrected most of the review issues. Created July 4, 2017, 7:57 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/FilterEngine.cpp
===================================================================
--- a/src/FilterEngine.cpp
+++ b/src/FilterEngine.cpp
@@ -175,47 +175,16 @@
return jsEngine->Evaluate("API.isAASubscription").Call(*this).AsBool();
}
bool Subscription::operator==(const Subscription& subscription) const
{
return GetProperty("url").AsString() == subscription.GetProperty("url").AsString();
}
-namespace
-{
- class Sync
sergei 2017/07/05 10:03:21 A minor thing, but do you mind to make this change
hub 2017/07/06 12:21:52 this require some patch surgery to make it worth i
- {
- public:
- Sync()
- :initialized(false)
- {
-
- }
- void Wait()
- {
- std::unique_lock<std::mutex> lock(mutex);
- while (!initialized)
- cv.wait(lock);
- }
- void Set()
- {
- {
- std::unique_lock<std::mutex> lock(mutex);
- initialized = true;
- }
- cv.notify_all();
- }
- private:
- std::mutex mutex;
- std::condition_variable cv;
- bool initialized;
- };
-}
-
FilterEngine::FilterEngine(const JsEnginePtr& jsEngine)
: jsEngine(jsEngine), firstRun(false), updateCheckId(0)
{
}
void FilterEngine::CreateAsync(const JsEnginePtr& jsEngine,
const FilterEngine::OnCreatedCallback& onCreated,
const FilterEngine::CreationParameters& params)
« no previous file with comments | « src/FileSystemJsObject.cpp ('k') | src/JsEngine.cpp » ('j') | src/JsEngine.cpp » ('J')

Powered by Google App Engine
This is Rietveld