Issue 5235 - Refactoring on SharedPrefs

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.sbrowser.contentblocker;
 
 import android.app.AlertDialog;
 import android.content.Context;
 import android.content.DialogInterface;
-import android.content.SharedPreferences;
 import android.preference.DialogPreference;
 import android.preference.PreferenceCategory;
-import android.preference.PreferenceManager;
 import android.text.Html;
 import android.util.AttributeSet;
 import android.view.View;
 
 import org.adblockplus.adblockplussbrowser.R;
 import org.adblockplus.sbrowser.contentblocker.engine.Engine;
 import org.adblockplus.sbrowser.contentblocker.engine.EngineService;
+import org.adblockplus.sbrowser.contentblocker.util.SharedPrefsUtils;
 
 import java.util.Collections;
 import java.util.Set;
 import java.util.TreeSet;
 
 public class WhitelistedWebsitesPreferenceCategory extends PreferenceCategory
 {
   private final Set<String> whitelistedWebsites = new TreeSet<>();
   private Engine engine;
 
@@ skipping 19 matching lines @@
               return;
             }
             WhitelistedWebsitesPreferenceCategory.this.engine = engine;
             WhitelistedWebsitesPreferenceCategory.this.initEntries();
           }
         });
   }
 
   private void initEntries()
   {
-    final SharedPreferences prefs =
-        PreferenceManager.getDefaultSharedPreferences(this.getContext().getApplicationContext());
-    final String key = this.getContext().getString(R.string.key_whitelisted_websites);
+    final Set<String> whitelistedWebsites = SharedPrefsUtils.getStringSet(
+        this.getContext(), R.string.key_whitelisted_websites, Collections.<String>emptySet());
+
     this.whitelistedWebsites.clear();
-    this.whitelistedWebsites.addAll(prefs.getStringSet(key, Collections.<String>emptySet()));
+    this.whitelistedWebsites.addAll(whitelistedWebsites);
     this.refreshEntries();
   }
 
   private void refreshEntries()
   {
     this.removeAll();
     for (final String url : this.whitelistedWebsites)
     {
       final WhitelistedWebsitePreference whitelistedWebsitePreference =
           new WhitelistedWebsitePreference(this.getContext(), url, new DialogInterface.OnClickListener()
@@ skipping 19 matching lines @@
       {
         WhitelistedWebsitesPreferenceCategory.this.whitelistWebsite(url);
       }
     });
     this.addPreference(urlPreference);
   }
 
   private void whitelistWebsite(String url)
   {
     this.whitelistedWebsites.add(url);
-    final SharedPreferences prefs =
-        PreferenceManager.getDefaultSharedPreferences(this.getContext().getApplicationContext());
-    final String key = this.getContext().getString(R.string.key_whitelisted_websites);
-    prefs.edit().putStringSet(key, this.whitelistedWebsites).apply();
-    this.refreshEntries();
-    this.engine.requestUpdateBroadcast();
+    this.storeWhitelistedWebsites();
   }
 
   private void removeWhitelistedWebsite(String url)
   {
     this.whitelistedWebsites.remove(url);
-    final SharedPreferences prefs =
-        PreferenceManager.getDefaultSharedPreferences(this.getContext().getApplicationContext());
-    final String key = this.getContext().getString(R.string.key_whitelisted_websites);
-    prefs.edit().putStringSet(key, this.whitelistedWebsites).apply();
+    this.storeWhitelistedWebsites();
+  }
+
+  private void storeWhitelistedWebsites() {
+    SharedPrefsUtils.putStringSet(
+        this.getContext(), R.string.key_whitelisted_websites, this.whitelistedWebsites);
     this.refreshEntries();
     this.engine.requestUpdateBroadcast();
   }
 
   private static class WhitelistedWebsitePreference extends DialogPreference
   {
     private final DialogInterface.OnClickListener onDeleteClickListener;
 
     WhitelistedWebsitePreference(Context context, String url,
         DialogInterface.OnClickListener onDeleteClickListener)
@@ skipping 43 matching lines @@
         {
           if (WhitelistedWebsitePreference.this.onDeleteClickListener != null)
           {
             WhitelistedWebsitePreference.this.onDeleteClickListener.onClick(dialog, which);
           }
         }
       });
     }
   }
 }