Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29449609: Issue 5242 - Adjust setIcon() methods in UrlInputOpenerPreference (Closed)

Created:
May 26, 2017, 9:37 p.m. by diegocarloslima
Modified:
June 1, 2017, 9:40 p.m.
Reviewers:
anton, jens
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5242 - Adjust setIcon() methods in UrlInputOpenerPreference

Patch Set 1 #

Patch Set 2 : Theres actually no need at all for overriding setIcon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/UrlInputOpenerPreference.java View 1 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
May 26, 2017, 9:39 p.m. (2017-05-26 21:39:13 UTC) #1
anton
On 2017/05/26 21:39:13, diegocarloslima wrote: LGTM
May 29, 2017, 5:33 a.m. (2017-05-29 05:33:51 UTC) #2
jens
On 2017/05/26 21:39:13, diegocarloslima wrote: LGTM
May 30, 2017, 7:20 a.m. (2017-05-30 07:20:02 UTC) #3
jens
On 2017/05/26 21:39:13, diegocarloslima wrote: LGTM
May 31, 2017, 3 p.m. (2017-05-31 15:00:09 UTC) #4
anton
June 1, 2017, 6:27 a.m. (2017-06-01 06:27:38 UTC) #5
On 2017/05/26 21:39:13, diegocarloslima wrote:

LGTM

Powered by Google App Engine
This is Rietveld