Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 29450608: Issue 5279 - Fix broken I/O in non-Firefox applications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Wladimir Palant
Modified:
2 years, 5 months ago
Reviewers:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Issue 5279 - Fix broken I/O in non-Firefox applications

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -38 lines) Patch
M lib/io.js View 1 4 chunks +74 lines, -38 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
2 years, 5 months ago (2017-05-29 11:54:39 UTC) #1
Felix Dahlke
Looks a _lot_ better than before! https://codereview.adblockplus.org/29450608/diff/29450609/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29450608/diff/29450609/lib/io.js#newcode249 lib/io.js:249: "readFromFile", "copyFile", "renameFile", ...
2 years, 5 months ago (2017-05-29 12:22:30 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29450608/diff/29450609/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29450608/diff/29450609/lib/io.js#newcode249 lib/io.js:249: "readFromFile", "copyFile", "renameFile", "removeFile", "statFile" On 2017/05/29 12:22:30, Felix ...
2 years, 5 months ago (2017-05-29 12:41:23 UTC) #3
Felix Dahlke
2 years, 5 months ago (2017-05-29 12:51:09 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5