Issue 4907 - Update v8 to 5.7.278 in libadblockplus

README.md

 libadblockplus
 ==============
 
 A C++ library offering the core functionality of Adblock Plus.
 
 Getting/updating the dependencies
 ---------------------------------
 
 libadblockplus has dependencies that aren't part of this repository. They are
 retrieved and updated during the build process, but you can also manually update
 them by running the following:
 
     ./ensure_dependencies.py
 
 Building
 --------
 
 ### Supported target platforms and prerequisites
 
 You need a C++11 compatible compiler to build libadblockplus.
 
 Win32:
-* Microsoft Visual Studio 2010, 2012
+* Microsoft Visual Studio 2015

[Eric, 2017/05/30 17:31:40]

We need to say here that VS 2017 will not work. Ordinary people will not assume
a specific version dependency.

[sergei, 2017/05/31 12:47:10]

Should we say in addition that VS 2020 and 2030 will not work? BTW, 2017 maybe
does work, at least as editor, I have not tested on it.

I have changed this line to a new one mentioning minimal toolset because other
lines are about compilers, not about IDE.

 
 Linux:
 * g++ 5.2
 
 Mac:
 * clang 3.6 for OS X
 
 Android:
 * The host system should be Linux or OS X
-* android-ndk-r9, android-ndk-r10c. You can download the latter for [OS X](http://dl.google.com/android/ndk/android-ndk-r10c-darwin-x86_64.bin), [Linux 32](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86.bin), [Linux 64](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86_64.bin).
+* android-ndk-r12b Here are the links for downloading
+  [OS X](https://dl.google.com/android/repository/android-ndk-r12b-darwin-x86_64.zip), 
+  [Linux 64](https://dl.google.com/android/repository/android-ndk-r12b-linux-x86_64.zip).
 * g++ multilib
 
 If you have a compilation issue with another compiler please [create an issue](https://issues.adblockplus.org/).
 
 ### Unix
 
 All you need is Python 2.7 and Make:
 
     make
 
-The default target architecture is x64. On a 32 bit system, run:
+The default target architecture is the architecture of a host. In order to build for a different architecture pass `ARCH` to `make`, e.g. run:
 
     make ARCH=ia32
 
+supported values are `ia32` and `x64`.
+    
+
 To build and run the tests:
 
     make test
 
-Likewise, use the following on a 32 bit system:
+Likewise, use the following with `ARCH`:
 
     make test ARCH=ia32
 
 To run specific tests, you can specify a filter:
 
     make test FILTER=*.Matches
 
 ### Windows
 
-You need Microsoft Visual C++ (Express is sufficient) 2012
+You need Microsoft Visual C++ 2015 (Community Edition is sufficient)

[Eric, 2017/05/30 17:31:40]

Again, this should say that the C++ version in VS 2017 will not work.

Is there actually a toolset upgrade required? Yes, and it's hard-coded to an old
version, and that version isn't listed here.

It looks like this should say "You need Microsoft Visual Studio 2015 installed
with the default directories". There's a dependency on a hard coded path name
for "vcvars32.bat".

[sergei, 2017/05/31 12:47:10]

I'm not sure about it, as far as I know it's possible to install v140 toolset in
MSVS 2017, and v141 should be compatible with v140, so maybe it does work there.
The toolset is added above where compilers are listed.
I have added that it's tested with MSVS 2015 CE, it will be updated as soon as
we know whether it works with MSVS 2017 and what actions are required.

 and Python 2.7. Make sure that `python.exe` is on your `PATH`.
 
 * Execute `createsolution.bat` to generate project files, this will create
 `build\ia32\libadblockplus.sln` (solution for the 32 bit build) and
 `build\x64\libadblockplus.sln` (solution for the 64 bit build). Unfortunately,
 V8 doesn't support creating both from the same project files.
 * Open `build\ia32\libadblockplus.sln` or `build\x64\libadblockplus.sln` in
 Visual Studio and build the solution there. Alternatively you can use the
 `msbuild` command line tool, e.g. run `msbuild /m build\ia32\libadblockplus.sln`
 from the Visual Studio Developer Command Prompt to create a 32 bit debug build.
@@ skipping 163 matching lines @@
 
 ### Unix
 
 The shell is automatically built by `make`, you can run it as follows:
 
     build/out/abpshell
 
 ### Windows
 
 Just run the project *abpshell*.