android-v8-options.gypi - Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: android-v8-options.gypi

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created May 30, 2017, 3:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {

	2 'variables': {

	3 'want_separate_host_toolset%': 1,

	4 'android_ndk_root': '<!(echo ${ANDROID_NDK_ROOT})',

	5 'clang_dir': '/usr/',
	sergei 2017/05/30 15:21:32 "/usr/" is a new magic string here, not sure wheth "/usr/" is a new magic string here, not sure whether it should be already configurable though. If so, what about making it as a part of a new issue? Eric 2017/05/30 17:31:40 Since you're already asking for default installati Show quoted text On 2017/05/30 15:21:32, sergei wrote: > "/usr/" is a new magic string here, not sure whether it should be already > configurable though. If so, what about making it as a part of a new issue? Since you're already asking for default installation directories for Windows, no reason not to document that Clang must also be installed in the default location. sergei 2017/05/31 12:47:11 I'm pretty sure that there is no default location Show quoted text On 2017/05/30 17:31:40, Eric wrote: > On 2017/05/30 15:21:32, sergei wrote: > > "/usr/" is a new magic string here, not sure whether it should be already > > configurable though. If so, what about making it as a part of a new issue? > > Since you're already asking for default installation directories for Windows, no > reason not to document that Clang must also be installed in the default > location. I'm pretty sure that there is no default location for clang, because it highly depends on a system and the package managing system. I would rather prefer to have it configurable and required. However I think it should not stop the current change.
	6 'make_clang_dir': '/usr/',

	7 },

	8 'conditions': [[

	9 'v8_target_arch=="arm"', {

	10 'variables': {

	11 'arm_version%': 7,

	12 'arm_fpu%': 'default',

	13 'arm_float_abi%': 'default',

	14 'arm_thumb%': 'default',

	15 }

	16 }

	17 ]],

	18 'includes': ['v8.gypi'],

	19 }

OLD	NEW

« README.md ('K') | « README.md ('k') | build-v8.cmd » ('j') | build-v8.cmd » ('J')