dependencies - Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: dependencies

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created May 30, 2017, 3:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = adblockpluscore/buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

	3 buildtools = buildtools hg: git:https://github.com/xxxz/buildtools.git@8c6d37906 df5761d71a86d680293f601e4e8dee3
	sergei 2017/05/30 15:21:32 This line will be changed as soon as decision abou This line will be changed as soon as decision about the fix in buildtools is made. The current line won't be pushed. sergei 2017/06/02 07:22:17 Done. Show quoted text On 2017/05/30 15:21:32, sergei wrote: > This line will be changed as soon as decision about the fix in buildtools is > made. The current line won't be pushed. Done.
3 adblockpluscore = adblockpluscore hg:103fdc164738 git:199dffdec708afd3913665e358 2868aa4a110d97	4 adblockpluscore = adblockpluscore hg:103fdc164738 git:199dffdec708afd3913665e358 2868aa4a110d97

4 third_party/googletest = googletest-github hg:368e1f54e5f6 git:d225acc90bc3a8c42 0a9bcd1f033033c1ccd7fe0	5 third_party/googletest = googletest-github hg:368e1f54e5f6 git:d225acc90bc3a8c42 0a9bcd1f033033c1ccd7fe0

5 third_party/gyp = gyp hg:fa4a16faa5ce git:8035ac9	6 third_party/gyp = gyp hg:2488397072ad git:8ffe7e7b1b82890a7e9ea21176bf039b6c5316 7b

6 third_party/v8 = v8-googlesource hg:28969bee9861 git:6bcca144a974f97d9496d3f7b53 8f90208f89c2e	7 third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe 309ba9c2e3081

	8 third_party/v8/base/trace_event/common = chromium-trace_event-common hg:afa6c508 d4a7 git:06294c8a4a6f744ef284cd63cfe54dbf61eea290

	9 third_party/v8/build = chromium-src-build hg:71b1606b07cf git:3983535ba9ae6e2dc5 01e59fde158018d811f95c

	10 third_party/v8/testing/gtest = googletest-github hg:324727ee9ad7 git:6f8a66431cb 592dad629028a50b3dd418a408c87

	11 third_party/v8/tools/gyp = gyp hg:9282ef983052 git:e7079f0e0e14108ab0dba58728ff2 19637458563

	12 third_party/v8/tools/clang = chromium-src-tools-clang hg:24cee4531b21 git:286099 f3928097ad1602710b550dfc1ff5c22142
	Eric 2017/05/30 17:31:40 There's a dependency on a particular Google versio There's a dependency on a particular Google version of Clang??? That seems insane. It's certainly not needed on Windows. sergei 2017/05/31 12:47:11 It's not clang, it's some additions and tools and Show quoted text On 2017/05/30 17:31:40, Eric wrote: > There's a dependency on a particular Google version of Clang??? That seems > insane. It's certainly not needed on Windows. It's not clang, it's some additions and tools and these files are required by gyp files in order to generate Makefiles for v8 when it's built for android. Currently there is no way to say that a particular dependency should not be used on a particular platform or case. JIC, the size of this directory is few megabytes. Basically, with the current usage it's needed merely to get a hardcoded in scripts/update.py (it seems so) version of clang :).
	13 third_party/v8/third_party/icu = chromium-deps-icu hg:dcc0a556c207 git:9cd282874 0572ba6f694b9365236a8356fd06147

OLD	NEW

« createsolution.bat ('K') | « createsolution.bat ('k') | ensure_dependencies.py » ('j') | libadblockplus.gyp » ('J')