Issue 4907 - Update v8 to 5.7.278 in libadblockplus

build-v8.cmd

 @echo off
 SETLOCAL
 
-rem %1 - arch {ia32, x64}
-rem %2 - configuration {Release, Debug}
-set ARCH=%~1
-set CONFIGURATION=%~2
+rem %1 - MSBuildBinPath, e.g. c:\Program Files (x86)\MSBuild\14.0\Bin
+rem %2 - arch {ia32, x64}
+rem %3 - configuration {Release, Debug}
+rem %4 - platform toolset, e.g. v140
+set MsBuildBinPath=%~1
+set ARCH=%~2
+set CONFIGURATION=%~3
+set PlatformToolset=%~4
 
 pushd "%~dp0"
 
 @python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I v8.gypi --generator-output=build\%ARCH%\v8 -G msvs_version=2015 -Dtarget_arch=%ARCH% -Dhost_arch=%ARCH% third_party/v8/src/v8.gyp

[sergei, 2017/05/31 12:47:11]

I would like to keep 2015 here hardcoded for present because v8 gyp files rely
on it internally. Of course it would be better to use the same configuration for
all projects, but even with hardcoded 2015 for v8 the rest should work. We can
always come back to it later if we see that it works without the parameter or
does not work and some actions are required.

 
-@call "c:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\bin\vcvars32.bat"

[Eric, 2017/05/30 17:31:40]

This is completely ugly. I'm using VS 2017 ordinarily now, as will anybody
setting up a development environment from scratch. I still have VS 2015
installed, so this would run, but that won't be the case for others.

It looks as though the only reason to have this is to ensure "msbuild" is in the
path. Better just to document that requirement and get rid of a hard-coded path
to an yet-another superseded MS software version.

There's already a requirement to have a particular version of python in the
path, so it's not even new to need a special PATH environment in order to make
the build succeed.

[sergei, 2017/05/31 12:47:11]

Done. This script actually is not supposed to be manually called for present, as
it's currently called we can actually pass a path to msbuild binary directory,
what is done in the change.

-
-@msbuild /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p:Configuration=%CONFIGURATION% /target:v8_snapshot,v8_libplatform,v8_libsampler
+@"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p:PlatformToolset=%PlatformToolset% /p:Configuration=%CONFIGURATION% /target:v8_snapshot,v8_libplatform,v8_libsampler
 
 popd
 
 ENDLOCAL
 
-exit /b 0

[Eric, 2017/05/30 17:31:40]

Why suppress errors?  It seems that if there's an error in the script, you'd
want the build to halt.

[sergei, 2017/05/31 12:47:11]

Done.

+exit /b