createsolution.bat - Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: createsolution.bat

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Left Patch Set: Created May 30, 2017, 3:02 p.m.

Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 @echo off	1 @echo off

2	2

3 pushd %~dp0	3 pushd %~dp0

4	4

5 python ensure_dependencies.py	5 python ensure_dependencies.py

6	6

7 mkdir build\ia32\shell	7 mkdir build\ia32\shell

8 mkdir build\x64\shell	8 mkdir build\x64\shell

9 python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I libadblockplus.gypi --g enerator-output=build\ia32 -G msvs_version=2015 -Dtarget_arch=ia32 -Dhost_arch=i a32 libadblockplus.gyp	9 python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -G msvs_version=2015 -I li badblockplus.gypi --generator-output=build\ia32 -Dtarget_arch=ia32 -Dhost_arch=i a32 libadblockplus.gyp
Eric 2017/05/30 17:31:40 Here's another version dependency. Is it actually Here's another version dependency. Is it actually necessary? sergei 2017/05/31 12:47:11 It was already specified here and changing to a ne Show quoted text On 2017/05/30 17:31:40, Eric wrote: > Here's another version dependency. Is it actually necessary? It was already specified here and changing to a new version looks a smaller change in comparison with dropping the parameter at all. Anyway, since it seems working, let's try without it. sergei 2017/06/14 16:05:01 Without that flag it generates for Visual Studio 2 Show quoted text On 2017/05/31 12:47:11, sergei wrote: > On 2017/05/30 17:31:40, Eric wrote: > > Here's another version dependency. Is it actually necessary? > > It was already specified here and changing to a new version looks a smaller > change in comparison with dropping the parameter at all. Anyway, since it seems > working, let's try without it. Without that flag it generates for Visual Studio 2005 and MSVS 2017 requires a conversion. However with "-G msvs_version=2015" MSVS 2017 can open it and any conversion is optional, of course if v140 is installed (one can do it via adding "VC++ 2015.3 v140 toolset" feature). It seems reasonable to have 2015 here because the generated files are almost seamlessly supported by both 2015 and 2017 and less conversion is required. So, "-G msvs_version=2015" is restored.
10 python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I libadblockplus.gypi --ge nerator-output=build\x64 -G msvs_version=2015 -Dtarget_arch=x64 -Dhost_arch=x64 libadblockplus.gyp	10 python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -G msvs_version=2015 -I lib adblockplus.gypi --generator-output=build\x64 -Dtarget_arch=x64 -Dhost_arch=x64 libadblockplus.gyp

11 popd	11 popd

LEFT	RIGHT