Issue 4907 - Update v8 to 5.7.278 in libadblockplus

libadblockplus.gyp

 {
   'conditions': [[
     # We don't want to use curl on Windows and Android, skip the check there
     'OS=="win" or OS=="android"',
     {
       'variables': {
         'have_curl': 0
       }
     },
     {
       'variables': {
         'have_curl': '<!(python check_curl.py)'
       }
     }
   ],
   [
     'OS=="win"', {
       'targets': [{
         'target_name': 'build-v8',
         'type': 'none',
         'actions': [{
           'action_name': 'build-v8',
           'inputs': ['build-v8.cmd'],
           'outputs': [
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libplatform.lib',

[Eric, 2017/05/30 17:31:40]

Is there a reason for the explicit build instructions? Specifying VS project
dependencies explicitly with gyp "dependencies" data worked fine in the past.
This seems like a step backwards.

[sergei, 2017/05/31 12:47:12]

Now it does not work because gyp messes the configuration, so it was required to
exclude v8 gyp-files from our configuration.
It is indeed a step forward because it makes no sense to spend so much time on
building of v8 and it should be used in a compiled state. Having it built
separately here also simplifies the future switching to using of v8 binaries.

             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_0.lib',
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_1.lib',
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_2.lib',
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_3.lib',
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libbase.lib',
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libsampler.lib',
             'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_snapshot.lib',
           ],
           'action': [
             'cmd',
             '/C',
             'build-v8.cmd',
+            '$(MSBuildBinPath)',
             '<(target_arch)',
-            '<(CONFIGURATION_NAME)'
+            '<(CONFIGURATION_NAME)',
+            '$(PlatformToolset)'
           ]
         }],
       }]
     }
   ]],
   'includes': ['shell/shell.gyp'],
   'targets': [{
     'target_name': 'libadblockplus',
     'type': '<(library)',
     'xcode_settings':{},
@@ skipping 159 matching lines @@
         '--convert', '<@(library_files)',
         '--after', '<@(load_after_files)',
       ]
     }]
   },
   {
     'target_name': 'tests',
     'type': 'executable',
     'xcode_settings': {},
     'dependencies': [
-      'third_party/googletest.gyp:googletest_main',
+      'googletest.gyp:googletest_main',
       'libadblockplus'
     ],
     'sources': [
       'test/BaseJsTest.h',
       'test/BaseJsTest.cpp',
       'test/AppInfoJsObject.cpp',
       'test/ConsoleJsObject.cpp',
       'test/DefaultFileSystem.cpp',
       'test/FileSystemJsObject.cpp',
       'test/FilterEngine.cpp',
       'test/GlobalJsObject.cpp',
       'test/JsEngine.cpp',
       'test/JsValue.cpp',
       'test/Notification.cpp',
       'test/Prefs.cpp',
       'test/ReferrerMapping.cpp',
       'test/Thread.cpp',
       'test/UpdateCheck.cpp',
       'test/WebRequest.cpp'
     ],
     'msvs_settings': {
       'VCLinkerTool': {
         'SubSystem': '1',   # Console
         'EntryPointSymbol': 'mainCRTStartup',
       },
     },
   }]
 }