Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus.gypi

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Left Patch Set: Created May 30, 2017, 3:02 p.m.
Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « libadblockplus.gyp ('k') | make_gyp_wrapper.py » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': ['common.gypi'], 2 'includes': ['common.gypi'],
3 'conditions': [ 3 'conditions': [
4 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \ 4 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
5 or OS=="netbsd" or OS=="android"', { 5 or OS=="netbsd" or OS=="android"', {
sergei 2017/05/30 15:21:32 I used the old list of OSes (see also common.gypi)
6 'target_defaults': { 6 'target_defaults': {
7 'cflags_cc': [ '-Wall', '-W', '-Wno-unused-parameter', 7 'cflags_cc': [ '-Wall', '-W', '-Wno-unused-parameter',
8 '-Wnon-virtual-dtor', '-pedantic' ] 8 '-Wnon-virtual-dtor', '-pedantic' ]
9 }
10 }],
11 ['OS=="linux" and target_arch=="ia32"', {
12 'target_defaults': {
13 'cflags_cc': [ '-m32' ]
9 } 14 }
10 }], 15 }],
11 ['OS=="win"', { 16 ['OS=="win"', {
12 'target_defaults': { 17 'target_defaults': {
13 'conditions': [ 18 'conditions': [
14 ['target_arch=="x64"', { 19 ['target_arch=="x64"', {
15 'msvs_configuration_platform': 'x64' 20 'msvs_configuration_platform': 'x64'
16 }] 21 }]
17 ], 22 ],
18 'msvs_configuration_attributes': { 23 'msvs_configuration_attributes': {
19 'CharacterSet': '1', 24 'CharacterSet': '1',
20 }, 25 },
21 'msbuild_toolset': 'v140_xp',
Eric 2017/05/30 17:31:41 Why the XP version? Toolset 14.0 already won't wor
sergei 2017/05/31 12:47:12 Since there is no decision about dropping of _xp y
22 'defines': [ 26 'defines': [
23 'WIN32', 27 'WIN32',
24 ], 28 ],
25 'link_settings': { 29 'link_settings': {
26 'libraries': ['-lDbgHelp'], 30 'libraries': ['-lDbgHelp'],
27 }, 31 },
32 }
33 }],
34 ['OS=="mac" and target_arch=="ia32"', {
35 'xcode_settings': {
36 'ARCHS': ["i386"]
28 } 37 }
29 }], 38 }],
30 ], 39 ],
31 40
32 'target_defaults': { 41 'target_defaults': {
33 'configurations': { 42 'configurations': {
34 'Debug': { 43 'Debug': {
35 'defines': [ 44 'defines': [
36 'DEBUG' 45 'DEBUG'
37 ], 46 ],
(...skipping 18 matching lines...) Expand all
56 }, { 65 }, {
57 'RuntimeLibrary': '0', #/MT 66 'RuntimeLibrary': '0', #/MT
58 } 67 }
59 ]] 68 ]]
60 } 69 }
61 } 70 }
62 } 71 }
63 }, 72 },
64 } 73 }
65 } 74 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld