Issue 4907 - Update v8 to 5.7.278 in libadblockplus

msvs_gyp_wrapper.py

 #!/usr/bin/env python
 # coding: utf-8
 
 import os
 import sys
 
 base_dir = os.path.abspath(os.path.dirname(__file__))
 sys.path.append(os.path.join(base_dir, 'third_party', 'gyp', 'pylib'))
 import gyp
 import gyp.generator.msvs
 
 orig_fix_path = gyp.generator.msvs._FixPath
 
+# gyp is trying to expand parameters as paths and the fix prevents gyp from
+# doing it for particular parameters for particular tools.
+# Don't touch following js2c and build-v8 parameters
 dont_expand = [
 # js2c

[Eric, 2017/05/30 17:31:41]

# js2c paths

   'CORE', 'EXPERIMENTAL', 'off', 'EXTRAS', 'EXPERIMENTAL_EXTRAS',
 # build-v8

[Eric, 2017/05/30 17:31:41]

# build-v8 paths

The new comments only made sense to me when I was looking at the old code, so
they need some clarification.

[sergei, 2017/05/31 12:47:12]

they are not paths, they are parameters for js2c and for build-v8 tools what was
in the comment below. It is gyp trying to treat everything as paths and expand
them.
Added a comment before the array, although it's rather unrelated change here.

Interestingly that it does not expand just added $(MSBuildBinPath), maybe I will
look into it later.

   'ia32', 'x64'
 ]
 
 def _FixPath(path):
     if path in dont_expand:
-        # Don't touch js2c and build-v8 parameters
         return path
     return orig_fix_path(path)
 gyp.generator.msvs._FixPath = _FixPath
 
 if __name__ == '__main__':
     gyp.main(sys.argv[1:])