Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/Utils.cpp

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Left Patch Set: Created May 30, 2017, 3:02 p.m.
Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/Utils.h ('k') | src/WebRequestJsObject.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 else 42 else
43 return std::string(); 43 return std::string();
44 } 44 }
45 45
46 v8::Local<v8::String> Utils::ToV8String(v8::Isolate* isolate, const std::string& str) 46 v8::Local<v8::String> Utils::ToV8String(v8::Isolate* isolate, const std::string& str)
47 { 47 {
48 return v8::String::NewFromUtf8(isolate, str.c_str(), 48 return v8::String::NewFromUtf8(isolate, str.c_str(),
49 v8::String::NewStringType::kNormalString, str.length()); 49 v8::String::NewStringType::kNormalString, str.length());
50 } 50 }
51 51
52 void Utils::ThrowException(v8::Isolate* isolate, const std::string& str) 52 void Utils::ThrowExceptionInJS(v8::Isolate* isolate, const std::string& str)
53 { 53 {
54 isolate->ThrowException(Utils::ToV8String(isolate, str)); 54 isolate->ThrowException(Utils::ToV8String(isolate, str));
55 } 55 }
56 56
57 #ifdef _WIN32 57 #ifdef _WIN32
58 std::wstring Utils::ToUtf16String(const std::string& str) 58 std::wstring Utils::ToUtf16String(const std::string& str)
59 { 59 {
60 size_t length = str.size(); 60 size_t length = str.size();
61 if (length == 0) 61 if (length == 0)
62 return std::wstring(); 62 return std::wstring();
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 if (FAILED(hr)) 101 if (FAILED(hr))
102 { 102 {
103 throw std::runtime_error("CanonizeUrl failed\n"); 103 throw std::runtime_error("CanonizeUrl failed\n");
104 } 104 }
105 } 105 }
106 return canonizedUrl; 106 return canonizedUrl;
107 107
108 } 108 }
109 #endif 109 #endif
110 110
LEFTRIGHT

Powered by Google App Engine
This is Rietveld