Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/WebRequestJsObject.cpp

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Left Patch Set: Created May 30, 2017, 3:02 p.m.
Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/Utils.cpp ('k') | third_party/googletest.gyp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 namespace 95 namespace
96 { 96 {
97 void GETCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments) 97 void GETCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
98 { 98 {
99 try 99 try
100 { 100 {
101 AdblockPlus::JsEngine::ScheduleWebRequest(arguments); 101 AdblockPlus::JsEngine::ScheduleWebRequest(arguments);
102 } catch (const std::exception& e) 102 } catch (const std::exception& e)
103 { 103 {
104 return AdblockPlus::Utils::ThrowException(arguments.GetIsolate(), e.what() ); 104 return AdblockPlus::Utils::ThrowExceptionInJS(arguments.GetIsolate(), e.wh at());
105 } 105 }
106 } 106 }
107 } 107 }
108 108
109 AdblockPlus::JsValue& AdblockPlus::WebRequestJsObject::Setup( 109 AdblockPlus::JsValue& AdblockPlus::WebRequestJsObject::Setup(
110 AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj) 110 AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj)
111 { 111 {
112 obj.SetProperty("GET", jsEngine.NewCallback(::GETCallback)); 112 obj.SetProperty("GET", jsEngine.NewCallback(::GETCallback));
113 return obj; 113 return obj;
114 } 114 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld