dependencies - Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Left Patch Set: address comments Created May 31, 2017, 12:43 p.m.

Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg: git:https://github.com/xxxz/buildtools.git@8c6d37906 df5761d71a86d680293f601e4e8dee3	3 buildtools = buildtools hg:6ab9eb46db2a git:2f2bf1f217314022327d4bd9c39002e9248d cf7f

4 adblockpluscore = adblockpluscore hg:103fdc164738 git:199dffdec708afd3913665e358 2868aa4a110d97	4 adblockpluscore = adblockpluscore hg:103fdc164738 git:199dffdec708afd3913665e358 2868aa4a110d97

5 third_party/googletest = googletest-github hg:368e1f54e5f6 git:d225acc90bc3a8c42 0a9bcd1f033033c1ccd7fe0	5 third_party/googletest = googletest-github hg:368e1f54e5f6 git:d225acc90bc3a8c42 0a9bcd1f033033c1ccd7fe0

6 third_party/gyp = gyp hg:2488397072ad git:8ffe7e7b1b82890a7e9ea21176bf039b6c5316 7b	6 third_party/gyp = gyp hg:2488397072ad git:8ffe7e7b1b82890a7e9ea21176bf039b6c5316 7b

7 third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe 309ba9c2e3081	7 third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe 309ba9c2e3081

8 third_party/v8/base/trace_event/common = chromium-trace_event-common hg:afa6c508 d4a7 git:06294c8a4a6f744ef284cd63cfe54dbf61eea290	8 third_party/v8/base/trace_event/common = chromium-trace_event-common hg:afa6c508 d4a7 git:06294c8a4a6f744ef284cd63cfe54dbf61eea290

9 third_party/v8/build = chromium-src-build hg:71b1606b07cf git:3983535ba9ae6e2dc5 01e59fde158018d811f95c	9 third_party/v8/build = chromium-src-build hg:71b1606b07cf git:3983535ba9ae6e2dc5 01e59fde158018d811f95c

10 third_party/v8/testing/gtest = googletest-github hg:324727ee9ad7 git:6f8a66431cb 592dad629028a50b3dd418a408c87	10 third_party/v8/testing/gtest = googletest-github hg:324727ee9ad7 git:6f8a66431cb 592dad629028a50b3dd418a408c87

11 third_party/v8/tools/gyp = gyp hg:9282ef983052 git:e7079f0e0e14108ab0dba58728ff2 19637458563	11 third_party/v8/tools/gyp = gyp hg:9282ef983052 git:e7079f0e0e14108ab0dba58728ff2 19637458563

12 third_party/v8/tools/clang = chromium-src-tools-clang hg:24cee4531b21 git:286099 f3928097ad1602710b550dfc1ff5c22142	12 third_party/v8/tools/clang = chromium-src-tools-clang hg:24cee4531b21 git:286099 f3928097ad1602710b550dfc1ff5c22142

13 third_party/v8/third_party/icu = chromium-deps-icu hg:dcc0a556c207 git:9cd282874 0572ba6f694b9365236a8356fd06147	13 third_party/v8/third_party/icu = chromium-deps-icu hg:dcc0a556c207 git:9cd282874 0572ba6f694b9365236a8356fd06147

LEFT	RIGHT