build-v8.cmd - Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: build-v8.cmd

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Left Patch Set: rebase Created June 2, 2017, 7:13 a.m.

Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 @echo off	1 @echo off

2 SETLOCAL	2 SETLOCAL

3	3

4 rem %1 - MSBuildBinPath, e.g. c:\Program Files (x86)\MSBuild\14.0\Bin	4 rem %1 - MSBuildBinPath, e.g. c:\Program Files (x86)\MSBuild\14.0\Bin

5 rem %2 - arch {ia32, x64}	5 rem %2 - arch {ia32, x64}

6 rem %3 - configuration {Release, Debug}	6 rem %3 - configuration {Release, Debug}

	7 rem %4 - platform toolset, e.g. v140

7 set MsBuildBinPath=%~1	8 set MsBuildBinPath=%~1

8 set ARCH=%~2	9 set ARCH=%~2

9 set CONFIGURATION=%~3	10 set CONFIGURATION=%~3

	11 set PlatformToolset=%~4

10	12

11 pushd "%~dp0"	13 pushd "%~dp0"

12	14

13 @python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I v8.gypi --generat or-output=build\%ARCH%\v8 -G msvs_version=2015 -Dtarget_arch=%ARCH% -Dhost_arch= %ARCH% third_party/v8/src/v8.gyp	15 @python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I v8.gypi --generat or-output=build\%ARCH%\v8 -G msvs_version=2015 -Dtarget_arch=%ARCH% -Dhost_arch= %ARCH% third_party/v8/src/v8.gyp

14	16

15 @"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p: Configuration=%CONFIGURATION% /target:v8_snapshot,v8_libplatform,v8_libsampler	17 @"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p: PlatformToolset=%PlatformToolset% /p:Configuration=%CONFIGURATION% /target:v8_sn apshot,v8_libplatform,v8_libsampler

16	18

17 popd	19 popd

18	20

19 ENDLOCAL	21 ENDLOCAL

20	22

21 exit /b	23 exit /b

LEFT	RIGHT