Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: build-v8.cmd

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Left Patch Set: add Xcode into readme Created June 2, 2017, 2:24 p.m.
Right Patch Set: independence from file mode of make_gyp_wrapper.py Created July 4, 2017, 11:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « android-v8-options.gypi ('k') | common.gypi » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 @echo off 1 @echo off
2 SETLOCAL 2 SETLOCAL
3 3
4 rem %1 - MSBuildBinPath, e.g. c:\Program Files (x86)\MSBuild\14.0\Bin 4 rem %1 - MSBuildBinPath, e.g. c:\Program Files (x86)\MSBuild\14.0\Bin
Oleksandr 2017/06/03 00:40:13 How about making the first parameter optional and
sergei 2017/06/14 16:05:01 Currently it's not needed because that script is n
5 rem %2 - arch {ia32, x64} 5 rem %2 - arch {ia32, x64}
6 rem %3 - configuration {Release, Debug} 6 rem %3 - configuration {Release, Debug}
7 rem %4 - platform toolset, e.g. v140
7 set MsBuildBinPath=%~1 8 set MsBuildBinPath=%~1
8 set ARCH=%~2 9 set ARCH=%~2
9 set CONFIGURATION=%~3 10 set CONFIGURATION=%~3
11 set PlatformToolset=%~4
10 12
11 pushd "%~dp0" 13 pushd "%~dp0"
12 14
13 @python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I v8.gypi --generat or-output=build\%ARCH%\v8 -G msvs_version=2015 -Dtarget_arch=%ARCH% -Dhost_arch= %ARCH% third_party/v8/src/v8.gyp 15 @python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I v8.gypi --generat or-output=build\%ARCH%\v8 -G msvs_version=2015 -Dtarget_arch=%ARCH% -Dhost_arch= %ARCH% third_party/v8/src/v8.gyp
Oleksandr 2017/06/03 00:40:13 I have tried building using VS2017, and it works s
sergei 2017/06/14 16:05:01 V8 project files don't require conversion when one
Oleksandr 2017/07/03 21:50:38 Acknowledged.
14 16
15 @"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p: Configuration=%CONFIGURATION% /target:v8_snapshot,v8_libplatform,v8_libsampler 17 @"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p: PlatformToolset=%PlatformToolset% /p:Configuration=%CONFIGURATION% /target:v8_sn apshot,v8_libplatform,v8_libsampler
Oleksandr 2017/06/03 00:40:13 It's a lot of building. How about adding /maxcpuco
sergei 2017/06/14 16:05:01 What do you mean under a lot of building? Does /m
Oleksandr 2017/07/03 21:50:38 Looks like I have missed the /m switch in this lin
16 18
17 popd 19 popd
18 20
19 ENDLOCAL 21 ENDLOCAL
20 22
21 exit /b 23 exit /b
LEFTRIGHT

Powered by Google App Engine
This is Rietveld