Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created May 30, 2017, 3:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: README.md
diff --git a/README.md b/README.md
index d4e94146851d2167587805293b162ac6c38a5b4f..36cfb00b38fa704f845a3faaa5e7defb01d1c239 100644
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@ Building
You need a C++11 compatible compiler to build libadblockplus.
-* Microsoft Visual Studio 2010, 2012
+* Microsoft Visual Studio 2015
Eric 2017/05/30 17:31:40 We need to say here that VS 2017 will not work. Or
sergei 2017/05/31 12:47:10 Should we say in addition that VS 2020 and 2030 wi
* g++ 5.2
@@ -30,7 +30,9 @@ Mac:
* The host system should be Linux or OS X
-* android-ndk-r9, android-ndk-r10c. You can download the latter for [OS X](http://dl.google.com/android/ndk/android-ndk-r10c-darwin-x86_64.bin), [Linux 32](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86.bin), [Linux 64](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86_64.bin).
+* android-ndk-r12b Here are the links for downloading
+ [OS X](https://dl.google.com/android/repository/android-ndk-r12b-darwin-x86_64.zip),
+ [Linux 64](https://dl.google.com/android/repository/android-ndk-r12b-linux-x86_64.zip).
* g++ multilib
If you have a compilation issue with another compiler please [create an issue](https://issues.adblockplus.org/).
@@ -41,15 +43,18 @@ All you need is Python 2.7 and Make:
-The default target architecture is x64. On a 32 bit system, run:
+The default target architecture is the architecture of a host. In order to build for a different architecture pass `ARCH` to `make`, e.g. run:
make ARCH=ia32
+supported values are `ia32` and `x64`.
To build and run the tests:
make test
-Likewise, use the following on a 32 bit system:
+Likewise, use the following with `ARCH`:
make test ARCH=ia32
@@ -59,7 +64,7 @@ To run specific tests, you can specify a filter:
### Windows
-You need Microsoft Visual C++ (Express is sufficient) 2012
+You need Microsoft Visual C++ 2015 (Community Edition is sufficient)
Eric 2017/05/30 17:31:40 Again, this should say that the C++ version in VS
sergei 2017/05/31 12:47:10 I'm not sure about it, as far as I know it's possi
and Python 2.7. Make sure that `python.exe` is on your `PATH`.
* Execute `createsolution.bat` to generate project files, this will create

Powered by Google App Engine
This is Rietveld