Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: createsolution.bat

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created May 30, 2017, 3:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: createsolution.bat
diff --git a/createsolution.bat b/createsolution.bat
index be626767b939a07a7bcc170ff341762ef5222df5..2ee128fcb2785991e7b167184db196d37dde5ddb 100644
--- a/createsolution.bat
+++ b/createsolution.bat
@@ -1,8 +1,11 @@
@echo off
pushd %~dp0
+
+python ensure_dependencies.py
+
mkdir build\ia32\shell
mkdir build\x64\shell
-python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator-output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 -Dhost_arch=ia32 libadblockplus.gyp
-python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator-output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 -Dhost_arch=x64 libadblockplus.gyp
+python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I libadblockplus.gypi --generator-output=build\ia32 -G msvs_version=2015 -Dtarget_arch=ia32 -Dhost_arch=ia32 libadblockplus.gyp
Eric 2017/05/30 17:31:40 Here's another version dependency. Is it actually
sergei 2017/05/31 12:47:11 It was already specified here and changing to a ne
sergei 2017/06/14 16:05:01 Without that flag it generates for Visual Studio 2
+python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I libadblockplus.gypi --generator-output=build\x64 -G msvs_version=2015 -Dtarget_arch=x64 -Dhost_arch=x64 libadblockplus.gyp
popd

Powered by Google App Engine
This is Rietveld