Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: msvs_gyp_wrapper.py

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created May 30, 2017, 3:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: msvs_gyp_wrapper.py
diff --git a/msvs_gyp_wrapper.py b/msvs_gyp_wrapper.py
index 2008a097a80b3f0cd03f63cfcbca20334e4af8f4..06a7b8a831b4867d3196ffcbae35e8c4a5a3d187 100755
--- a/msvs_gyp_wrapper.py
+++ b/msvs_gyp_wrapper.py
@@ -11,10 +11,16 @@ import gyp.generator.msvs
orig_fix_path = gyp.generator.msvs._FixPath
+dont_expand = [
+# js2c
Eric 2017/05/30 17:31:41 # js2c paths
+ 'CORE', 'EXPERIMENTAL', 'off', 'EXTRAS', 'EXPERIMENTAL_EXTRAS',
+# build-v8
Eric 2017/05/30 17:31:41 # build-v8 paths The new comments only made sense
sergei 2017/05/31 12:47:12 they are not paths, they are parameters for js2c a
+ 'ia32', 'x64'
+]
def _FixPath(path):
- if path == 'CORE' or path == 'EXPERIMENTAL' or path == 'off':
- # Don't touch js2c parameters
+ if path in dont_expand:
+ # Don't touch js2c and build-v8 parameters
return path
return orig_fix_path(path)
gyp.generator.msvs._FixPath = _FixPath

Powered by Google App Engine
This is Rietveld