Unified Diff: src/Utils.h
Issue 29451722:
Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed)
Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set:
Created May 30, 2017, 3:02 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« msvs_gyp_wrapper.py ('K')
|
« src/JsValue.cpp ('k')
|
src/Utils.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/Utils.h |
| diff --git a/src/Utils.h b/src/Utils.h |
| index bb6300858055744ad48c6b07917f9a36113f7ac9..98a277a742ab8daa7118af66d73ab64fe76f7f7c 100644 |
| --- a/src/Utils.h |
| +++ b/src/Utils.h |
| @@ -32,6 +32,7 @@ namespace AdblockPlus |
| std::string Slurp(std::istream& stream); |
| std::string FromV8String(const v8::Handle<v8::Value>& value); |
| v8::Local<v8::String> ToV8String(v8::Isolate* isolate, const std::string& str); |
| + void ThrowException(v8::Isolate* isolate, const std::string& str); |
|
Eric
2017/05/30 17:31:41
Does this mean to throw a C++ exception or to thro
sergei
2017/05/31 12:47:12
It's still unclear, changed to `ThrowExceptionInJS
|
| // Code for templated function has to be in a header file, can't be in .cpp |
| template<class T> |
« msvs_gyp_wrapper.py ('K')
|
« src/JsValue.cpp ('k')
|
src/Utils.cpp » ('j')
|
no next file with comments »
