Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: msvs_gyp_wrapper.py

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: fix support of ARCH=ia32 Created June 2, 2017, 7:19 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« README.md ('K') | « make_gyp_wrapper.py ('k') | shell/shell.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: msvs_gyp_wrapper.py
diff --git a/msvs_gyp_wrapper.py b/msvs_gyp_wrapper.py
index 2008a097a80b3f0cd03f63cfcbca20334e4af8f4..d1ad88c2a02905078c61ef8bf7c1c5afb0d58258 100755
--- a/msvs_gyp_wrapper.py
+++ b/msvs_gyp_wrapper.py
@@ -11,10 +11,18 @@ import gyp.generator.msvs
orig_fix_path = gyp.generator.msvs._FixPath
+# gyp is trying to expand parameters as paths and the fix prevents gyp from
+# doing it for particular parameters for particular tools.
+# Don't touch following js2c and build-v8 parameters
+dont_expand = [
+# js2c
+ 'CORE', 'EXPERIMENTAL', 'off', 'EXTRAS', 'EXPERIMENTAL_EXTRAS',
+# build-v8
+ 'ia32', 'x64'
+]
def _FixPath(path):
- if path == 'CORE' or path == 'EXPERIMENTAL' or path == 'off':
- # Don't touch js2c parameters
+ if path in dont_expand:
return path
return orig_fix_path(path)
gyp.generator.msvs._FixPath = _FixPath
« README.md ('K') | « make_gyp_wrapper.py ('k') | shell/shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld