Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/scss/components/_groups.scss

Issue 29453600: Issue 4961 - Fix card group field alignment on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Created June 1, 2017, 1:10 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 // This file is part of acceptableads.org. 1 // This file is part of acceptableads.org.
2 // Copyright (C) 2016 Eyeo GmbH 2 // Copyright (C) 2016 Eyeo GmbH
3 // 3 //
4 // acceptableads.org is free software: you can redistribute it and/or modify 4 // acceptableads.org is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // acceptableads.org is distributed in the hope that it will be useful, 9 // acceptableads.org is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 width: 100%; 274 width: 100%;
275 } 275 }
276 // un-center all cards 276 // un-center all cards
277 .group > div:nth-child(4), 277 .group > div:nth-child(4),
278 .group > div:nth-child(3), 278 .group > div:nth-child(3),
279 .group > div:nth-child(5) 279 .group > div:nth-child(5)
280 { 280 {
281 margin-left: 0; 281 margin-left: 0;
282 } 282 }
283 } 283 }
284
285 @supports (display: grid)
286 {
287
288 .group
289 {
290 display: grid;
291 // Each card should be a minimum width of the $card--max-width. Otherwise, t ake up available space
292 grid-template-columns: repeat(auto-fit, minmax($card--max-width, 1fr));
293 }
294
295 .group-4
ire 2017/06/01 13:14:35 I haven't dealt with other group sizes yet (e.g. g
juliandoucette 2017/06/09 14:51:12 Acknowledged.
296 {
297 @media (min-width: $desktop-breakpoint) {
298 // Each card should take a minimum of 25% width of the group
299 grid-template-columns: repeat(auto-fit, minmax(25%, 1fr));
300 }
301 }
302
303 .group-4 > div
juliandoucette 2017/06/09 14:51:12 NIT: I'm guessing that you are following the exist
ire 2017/06/12 14:28:54 Acknowledged.
304 {
305 width: 100%;
306 }
307
308 }
OLDNEW
« static/scss/components/_cards.scss ('K') | « static/scss/components/_cards.scss ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld