Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/scss/components/_cards.scss

Issue 29453600: Issue 4961 - Fix card group field alignment on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Restructure card markup and fixes Created June 13, 2017, 4:44 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 // This file is part of acceptableads.org. 1 // This file is part of acceptableads.org.
2 // Copyright (C) 2016 Eyeo GmbH 2 // Copyright (C) 2016 Eyeo GmbH
3 // 3 //
4 // acceptableads.org is free software: you can redistribute it and/or modify 4 // acceptableads.org is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // acceptableads.org is distributed in the hope that it will be useful, 9 // acceptableads.org is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 13 matching lines...) Expand all
24 background-color: $primary-bg; 24 background-color: $primary-bg;
25 } 25 }
26 26
27 .card %headings 27 .card %headings
28 { 28 {
29 @extend h3; 29 @extend h3;
30 height: $md + $sm; 30 height: $md + $sm;
31 margin: $sm 0 $sm 0; 31 margin: $sm 0 $sm 0;
32 } 32 }
33 33
34 .card article .card-heading
juliandoucette 2017/06/16 19:39:16 Why article?
ire 2017/06/21 07:47:57 I was selecting the cards on the `pages/committee/
35 {
36 height: auto;
37
38 @media (min-width: 700px)
juliandoucette 2017/06/16 19:39:16 Why 700?
ire 2017/06/21 07:47:57 Sorry, this was supposed to be the $tablet-breakpo
39 {
40 height: 120px;
41 }
42 }
43
34 .card-icon 44 .card-icon
35 { 45 {
36 margin: $sm 0; 46 margin: $sm 0;
37 } 47 }
38 48
39 .center .card-icon 49 .center .card-icon
40 { 50 {
41 margin: $lg - $sm 0 $md 0; 51 margin: $lg - $sm 0 $md 0;
42 } 52 }
43 53
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 .card.list a 139 .card.list a
130 { 140 {
131 text-decoration: none; 141 text-decoration: none;
132 color: $primary-fg; 142 color: $primary-fg;
133 } 143 }
134 144
135 .card.list a%active 145 .card.list a%active
136 { 146 {
137 color: $accent; 147 color: $accent;
138 } 148 }
149
150 @supports (display: grid)
151 {
152
153 .group .card
juliandoucette 2017/06/16 19:39:16 I think anything .group should go in _group.scss.
ire 2017/06/21 07:47:57 Acknowledged.
154 {
155 width: 100%;
156 grid-template-rows: auto 1fr auto;
157 }
158
159 .group .card .card-summary
160 {
161 @media all
juliandoucette 2017/06/16 19:39:17 Why @media all?
ire 2017/06/21 07:47:58 This is to override the various media queries that
162 {
163 height: auto;
164 }
165 }
166
167 .card-footer .m-t-md
168 {
169 margin-top: 0 !important;
ire 2017/06/13 16:51:23 This is to remove the large top margin that's on t
juliandoucette 2017/06/16 19:39:16 Perhaps this should go in includes/solutions/style
ire 2017/06/21 07:47:57 Okay I will move it then
170 }
171
172 }
OLDNEW

Powered by Google App Engine
This is Rietveld