Noissue - Lint adjustments and optimizations

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 16 matching lines @@
 
 import android.content.ContentProvider;
 import android.content.ContentValues;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.database.Cursor;
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.ParcelFileDescriptor;
 import android.preference.PreferenceManager;
+import android.support.annotation.NonNull;
 import android.util.Log;
 
 public class ContentBlockerContentProvider extends ContentProvider
 {
   private static final String TAG = ContentBlockerContentProvider.class.getSimpleName();
 
   @Override
-  public Bundle call(String method, String arg, Bundle extras)
+  public Bundle call(@NonNull String method, String arg, Bundle extras)
   {
     // As of SBC interface v1.4 we return `null` here to signal that we do not
     // use encryption
     return null;
   }
 
   private static boolean getBooleanPref(final SharedPreferences prefs, final String key,
       final boolean defValue)
   {
     try
     {
       return prefs.getBoolean(key, defValue);
     }
     catch (final Throwable t)
     {
       return defValue;
     }
   }
 
   private void setApplicationActivated()
   {
     final SharedPreferences prefs = PreferenceManager
         .getDefaultSharedPreferences(this.getContext().getApplicationContext());
     final String key = this.getContext().getString(R.string.key_application_activated);
     final boolean applicationActived = getBooleanPref(prefs, key, false);

[jens, 2017/06/02 10:50:00]

minor, but 'applicationActived' -> this typo could be fixed 

[diegocarloslima, 2017/06/02 21:03:41]

Acknowledged.

     if (!applicationActived)
     {
       prefs.edit()
           .putBoolean(key, true)
           .commit();
     }
   }
 
   @Override
-  public ParcelFileDescriptor openFile(final Uri uri, final String mode)
+  public ParcelFileDescriptor openFile(@NonNull final Uri uri, @NonNull final String mode)
       throws FileNotFoundException
   {
     try
     {
       this.setApplicationActivated();
       Log.d(TAG, "Writing filters...");
       final File filterFile = Engine.getOrCreateCachedFilterFile(getContext());
       Log.d(TAG, "Delivering filters...");
       return ParcelFileDescriptor.open(filterFile, ParcelFileDescriptor.MODE_READ_ONLY);
     }
     catch (IOException e)
     {
       Log.e(TAG, "File creation failed: " + e.getMessage(), e);
       return null;
     }
   }
 
   @Override
   public boolean onCreate()
   {
     Log.i(TAG, "onCreate() called");
     getContext().startService(new Intent(getContext(), EngineService.class));
     Log.i(TAG, "Requested service startup");
     return true;
   }
 
   @Override
-  public Cursor query(final Uri uri, final String[] projection, final String selection,
+  public Cursor query(@NonNull final Uri uri, final String[] projection, final String selection,
       final String[] selectionArgs, final String sortOrder)
   {
     return null;
   }
 
   @Override
-  public String getType(final Uri uri)
+  public String getType(@NonNull final Uri uri)
   {
     return null;
   }
 
   @Override
-  public Uri insert(final Uri uri, final ContentValues values)
+  public Uri insert(@NonNull final Uri uri, final ContentValues values)
   {
     return null;
   }
 
   @Override
-  public int delete(final Uri uri, final String selection, final String[] selectionArgs)
+  public int delete(@NonNull final Uri uri, final String selection, final String[] selectionArgs)
   {
     return 0;
   }
 
   @Override
-  public int update(final Uri uri, final ContentValues values, final String selection,
+  public int update(@NonNull final Uri uri, final ContentValues values, final String selection,
       final String[] selectionArgs)
   {
     return 0;
   }
 }