Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java

Issue 29453722: Noissue - Lint adjustments and optimizations (Closed)
Patch Set: Created June 1, 2017, 9:30 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 sb.append(DateUtils.formatDateTime(this.getContext(), timestamp, 125 sb.append(DateUtils.formatDateTime(this.getContext(), timestamp,
126 DateUtils.FORMAT_SHOW_DATE | DateUtils.FORMAT_SHOW_TIME)); 126 DateUtils.FORMAT_SHOW_DATE | DateUtils.FORMAT_SHOW_TIME));
127 } 127 }
128 else 128 else
129 { 129 {
130 sb.append(this.getContext().getString(R.string.last_update_never)) ; 130 sb.append(this.getContext().getString(R.string.last_update_never)) ;
131 } 131 }
132 cbp.setSummary(sb.toString()); 132 cbp.setSummary(sb.toString());
133 } 133 }
134 134
135 cbp.setTitle(this.getContext().getString(resInt.intValue())); 135 cbp.setTitle(this.getContext().getString(resInt));
136 cbp.setChecked(sub.isEnabled()); 136 cbp.setChecked(sub.isEnabled());
137 cbp.setPersistent(false); 137 cbp.setPersistent(false);
138 cbp.setKey(sub.getId()); 138 cbp.setKey(sub.getId());
139 cbp.setOnPreferenceChangeListener(this); 139 cbp.setOnPreferenceChangeListener(this);
140 this.addPreference(cbp); 140 this.addPreference(cbp);
141 } 141 }
142 } 142 }
143 } 143 }
144 } 144 }
145 145
146 @Override 146 @Override
147 public boolean onPreferenceChange(final Preference preference, final Object ne wValue) 147 public boolean onPreferenceChange(final Preference preference, final Object ne wValue)
148 { 148 {
149 final String id = preference.getKey(); 149 final String id = preference.getKey();
150 final boolean enabled = ((Boolean) newValue).booleanValue(); 150 final boolean enabled = ((Boolean) newValue);
anton 2017/06/02 07:39:56 minor: double brackets are not required, it could
diegocarloslima 2017/06/02 21:03:41 Acknowledged.
151 151
152 this.engine.changeSubscriptionState(id, enabled); 152 this.engine.changeSubscriptionState(id, enabled);
153 153
154 return true; 154 return true;
155 } 155 }
156 } 156 }
OLDNEW

Powered by Google App Engine
This is Rietveld