Noissue - Lint adjustments and optimizations

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 13 matching lines @@
 import java.net.URL;
 import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.locks.ReentrantLock;
 import android.annotation.SuppressLint;
-import android.content.Context;
 import android.util.Log;
 
 @SuppressLint("DefaultLocale")
 final class Downloader
 {
   private static final int MAX_RETRIES = 5;
 
   private static final String TAG = Downloader.class.getSimpleName();
   private final Engine engine;
   private final ReentrantLock accessLock = new ReentrantLock();
   private Thread downloaderThread;
-  private LinkedBlockingQueue<DownloadJob> downloadJobs = new LinkedBlockingQueue<>();
-  private HashSet<String> enqueuedIds = new HashSet<>();
+  private final LinkedBlockingQueue<DownloadJob> downloadJobs = new LinkedBlockingQueue<>();
+  private final HashSet<String> enqueuedIds = new HashSet<>();
   private boolean downloaderEnabled = true;
 
   private Downloader(final Engine engine)
   {
     this.engine = engine;
   }
 
   void lock()
   {
     this.accessLock.lock();
@@ skipping 12 matching lines @@
       Log.d(TAG, "Re-checking download permission");
     }
     this.downloaderEnabled = true;
     this.unlock();
   }
 
   static void download(final DownloadJob job) throws IOException
   {
     final HttpURLConnection connection = (HttpURLConnection) job.url.openConnection();
     connection.setRequestMethod("GET");
-    if (job.headers != null)
+    for (final Entry<String, String> e : job.headers.entrySet())
     {
-      for (final Entry<String, String> e : job.headers.entrySet())
-      {
-        connection.addRequestProperty(e.getKey(), e.getValue());
-      }
+      connection.addRequestProperty(e.getKey(), e.getValue());
     }
     connection.connect();
 
     job.responseCode = connection.getResponseCode();
     job.responseHeaders.clear();
     job.responseText = null;
 
     for (int i = 1;; i++)
     {
       final String key = connection.getHeaderFieldKey(i);
@@ skipping 27 matching lines @@
         this.enqueuedIds.add(id);
         this.downloadJobs.add(new DownloadJob(url, id, headers));
       }
     }
     finally
     {
       this.unlock();
     }
   }
 
-  public static Downloader create(final Context context, final Engine engine)
+  public static Downloader create(final Engine engine)
   {
     final Downloader downloader = new Downloader(engine);
 
     downloader.downloaderThread = new Thread(new DownloaderHandler(downloader));
     downloader.downloaderThread.setDaemon(true);
     downloader.downloaderThread.start();
 
     return downloader;
   }
 
@@ skipping 98 matching lines @@
   }
 
   private static class DownloadJob
   {
     private final URL url;
     private final String id;
     private final HashMap<String, String> headers = new HashMap<>();
     private int retryCount = 0;
 
     private int responseCode = 0;
-    private HashMap<String, String> responseHeaders = new HashMap<>();
+    private final HashMap<String, String> responseHeaders = new HashMap<>();
     private String responseText = null;
 
     public DownloadJob(final URL url, final String id, final Map<String, String> headers)
     {
       this.url = url;
       this.id = id;
       if (headers != null)
       {
         this.headers.putAll(headers);
       }
     }
   }
 }