Noissue - Lint adjustments and optimizations

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/SubscriptionInfo.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.sbrowser.contentblocker.engine;
 
+import android.support.annotation.NonNull;
+
 /**
  * Class for querying subscription information from the engine.
  */
 public class SubscriptionInfo implements Comparable<SubscriptionInfo>
 {
   public enum Type
   {
     ADS,
     OTHER,
     CUSTOM,
     INITIALIZING,
     USER_FILTERS,
     USER_EXCEPTIONS,
     ACCEPTABLE_ADS
   }
 
   private final Type type;
   private final String id;
   private final String url;
   private String title;
   private boolean enabled = false;
   private long lastUpdate;
 
   SubscriptionInfo(final Type type, final String id, final String url, final String title, final boolean enabled, final long lastUpdate)

[jens, 2017/06/02 10:50:01]

I think this constructor can be private, as we only use the static create()
method.

[diegocarloslima, 2017/06/02 21:03:42]

Acknowledged.

   {
     this.type = type;
     this.id = id;
     this.url = url;
     this.title = title;
     this.enabled = enabled;
     this.lastUpdate = lastUpdate;
   }
 
   public Type getType()
@@ skipping 87 matching lines @@
 
     return new SubscriptionInfo(type,
         subscription.getId(),
         url,
         title,
         subscription.isEnabled(),
         subscription.getLastUpdateTimestamp());
   }
 
   @Override
-  public int compareTo(final SubscriptionInfo another)
+  public int compareTo(@NonNull final SubscriptionInfo another)
   {
     return this.getTitle().compareTo(another.getTitle());
   }
 }