adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java - Issue 29453722: Noissue - Lint adjustments and optimizations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java

Issue 29453722: Noissue - Lint adjustments and optimizations (Closed)

Patch Set: Created June 1, 2017, 9:30 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java

===================================================================

--- a/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java

+++ b/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java

@@ -186,15 +186,15 @@ public class ListedSubscriptionsPreferen

}

@Override

public boolean onPreferenceChange(final Preference preference, final Object newValue)

{

final String id = preference.getKey();

- final boolean enabled = ((Boolean) newValue).booleanValue();

+ final boolean enabled = ((Boolean) newValue);

anton 2017/06/02 07:39:56 minor: double brackets are not required, it could

diegocarloslima 2017/06/02 21:03:41 Acknowledged.

this.engine.changeSubscriptionState(id, enabled);

return true;

}