Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29454619: Issue 4362 - Update and improve text on "Learn More" tab on adblockplus.org and rearrange links in … (Closed)

Created:
June 2, 2017, 12:06 p.m. by ire
Modified:
Aug. 9, 2017, 8:52 a.m.
Reviewers:
tamara, juliandoucette
CC:
Lisa, jeen
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 4362 - Update and improve text on "Learn More" tab on adblockplus.org and rearrange links in alphabetical order

Patch Set 1 #

Patch Set 2 : Remove inclues, place IDs before classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -102 lines) Patch
M includes/index.tmpl View 1 1 chunk +76 lines, -102 lines 0 comments Download

Messages

Total messages: 10
ire
June 2, 2017, 12:06 p.m. (2017-06-02 12:06:19 UTC) #1
ire
Some notes: I moved the content for each "Learn More" tab to a separate file ...
June 2, 2017, 12:11 p.m. (2017-06-02 12:11:27 UTC) #2
juliandoucette
> For some strings, I created a a new translation ID, but for others I ...
June 8, 2017, 10 p.m. (2017-06-08 22:00:50 UTC) #3
ire
I had an issue while uploading and somehow lost the inline comments :/ . Replying ...
June 9, 2017, 7:22 a.m. (2017-06-09 07:22:31 UTC) #4
juliandoucette
> I had an issue while uploading and somehow lost the inline comments :/ . ...
June 16, 2017, 5:43 p.m. (2017-06-16 17:43:16 UTC) #5
juliandoucette
LGTM - Except: @Tamara we have introduced a couple new string IDs here that we ...
June 16, 2017, 5:59 p.m. (2017-06-16 17:59:20 UTC) #6
ire
@Tamara: Any update on this? On 2017/06/16 17:59:20, juliandoucette wrote: > @Tamara we have introduced ...
June 28, 2017, 9:57 a.m. (2017-06-28 09:57:10 UTC) #7
tamara
On 2017/06/28 09:57:10, ire wrote: > @Tamara: Any update on this? > > On 2017/06/16 ...
June 28, 2017, 1:29 p.m. (2017-06-28 13:29:13 UTC) #8
ire
On 2017/06/28 13:29:13, tamara wrote: > I am really sorry for the delay, busy at ...
July 3, 2017, 10:18 a.m. (2017-07-03 10:18:27 UTC) #9
juliandoucette
Aug. 8, 2017, 8 p.m. (2017-08-08 20:00:02 UTC) #10
+Jeen +Lisa

RE: https://issues.adblockplus.org/ticket/4362#comment:17

Can/Should we push this change before we update the homepage this/next month?

- It could slightly improve our searchability
- We can wait for translations or push the change for English only

(I know that you answered this question in the comment that I linked. I am
asking again because I think that I am or may be providing new relevant
information above.)

Powered by Google App Engine
This is Rietveld