Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/edgeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)
Patch Set: remove chrome specific code from edge template, and edge specific from chrome Created June 7, 2017, 11:06 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4
5 "use strict";
6
7 let platform = "edgehtml";
8 let platformVersion = null;
9 let application = "edge";
10 let applicationVersion = "0";
11
12 let regexp = /(\S+)\/(\S+)(?:\s*\(.*?\))?/g;
13 let match;
14
15 while (match = regexp.exec(navigator.userAgent))
16 {
17 let app = match[1];
18 let ver = match[2];
19 platformVersion = ver;
20 }
21
22 // not a Chromium-based UA, probably modifed by the user
Jon Sonesen 2017/06/07 11:08:43 Not sure if I should change the comment, seems it
23 if (!platformVersion)
24 {
25 application = "unknown";
26 applicationVersion = platformVersion = "0";
27 }
28
29 exports.addonName = {{ basename|json }};
30 exports.addonVersion = {{ version|json }};
31
32 exports.application = application;
Sebastian Noack 2017/06/07 11:14:13 Since this code is only bundled with the build for
Jon Sonesen 2017/06/07 11:41:38 Acknowledged. What about the logic if platform ver
Sebastian Noack 2017/06/07 11:51:46 If the regular expression fails we should still se
Jon Sonesen 2017/06/07 13:09:28 Acknowledged.
33 exports.applicationVersion = applicationVersion;
34
35 exports.platform = platform;
36 exports.platformVersion = platformVersion;
OLDNEW

Powered by Google App Engine
This is Rietveld