templates/edgeInfo.js.tmpl - Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/edgeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)

Patch Set: readd chrome logic, remove more chrome specific code from edge tmpl Created June 7, 2017, 1:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 /* This Source Code Form is subject to the terms of the Mozilla Public

	2 * License, v. 2.0. If a copy of the MPL was not distributed with this

	3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

	4

	5 "use strict";

	6

	7

	8 let [app, platformVersion] = /(\S+)\/(\S+)(?:\s\(.?\))?/g.exec(navigator.userA gent);
	Sebastian Noack 2017/06/07 13:26:13 Obviously, you didn't test that code. At very leas Obviously, you didn't test that code. At very least you could have tried out the regexp on a real user agent string, if you don't care to run MS Edge: https://stackoverflow.com/questions/30591706/what-is-the-user-agent-string-na... Jon Sonesen 2017/06/07 13:56:07 My apologies, I made a mistake in my testing and j Show quoted text On 2017/06/07 13:26:13, Sebastian Noack wrote: > Obviously, you didn't test that code. At very least you could have tried out the > regexp on a real user agent string, if you don't care to run MS Edge: > https://stackoverflow.com/questions/30591706/what-is-the-user-agent-string-na... My apologies, I made a mistake in my testing and just was checking the regex passed but not paying attention to the values. Definitely will be more careful.
	9

	10 // If regular expression fails, still set platformVersion to "0"

	11 if (!platformVersion)

	12 platformVersion = "0";

	13

	14 exports.addonName = {{ basename\|json }};

	15 exports.addonVersion = {{ version\|json }};

	16

	17 exports.application = "edge";

	18 exports.applicationVersion = "0";

	19

	20 exports.platform = "edgehtml"

	21 exports.platformVersion = platformVersion;

OLD	NEW

« templates/chromeInfo.js.tmpl ('K') | « templates/chromeInfo.js.tmpl ('k') | templates/modules.js.tmpl » ('j') | no next file with comments »