Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/chromeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)
Patch Set: fix regexp in edge tmpl, remove platformVersion from chrome tmpl Created June 7, 2017, 4:17 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | templates/edgeInfo.js.tmpl » ('j') | templates/edgeInfo.js.tmpl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this 2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 "use strict"; 5 "use strict";
6 6
7 let platform = "chromium";
8 let platformVersion = null; 7 let platformVersion = null;
9 let application = null; 8 let application = null;
10 let applicationVersion; 9 let applicationVersion;
11 10
12 let regexp = /(\S+)\/(\S+)(?:\s*\(.*?\))?/g; 11 let regexp = /(\S+)\/(\S+)(?:\s*\(.*?\))?/g;
13 let match; 12 let match;
14 13
15 while (match = regexp.exec(navigator.userAgent)) 14 while (match = regexp.exec(navigator.userAgent))
16 { 15 {
17 let app = match[1]; 16 let app = match[1];
18 let ver = match[2]; 17 let ver = match[2];
19 18
20 if (app == "Chrome") 19 if (app == "Chrome")
21 { 20 {
22 platformVersion = ver; 21 platformVersion = ver;
23 } 22 }
24 else if (app == "Edge")
25 {
26 platform = "edgehtml";
27 platformVersion = ver;
28 application = "edge";
29 applicationVersion = "0";
30 }
31 else if (app != "Mozilla" && app != "AppleWebKit" && app != "Safari") 23 else if (app != "Mozilla" && app != "AppleWebKit" && app != "Safari")
32 { 24 {
33 // For compatibility with legacy websites, Chrome's UA 25 // For compatibility with legacy websites, Chrome's UA
34 // also includes a Mozilla, AppleWebKit and Safari token. 26 // also includes a Mozilla, AppleWebKit and Safari token.
35 // Any further name/version pair indicates a fork. 27 // Any further name/version pair indicates a fork.
36 application = app == "OPR" ? "opera" : app.toLowerCase(); 28 application = app == "OPR" ? "opera" : app.toLowerCase();
37 applicationVersion = ver; 29 applicationVersion = ver;
38 } 30 }
39 } 31 }
40 32
(...skipping 11 matching lines...) Expand all
52 applicationVersion = platformVersion; 44 applicationVersion = platformVersion;
53 } 45 }
54 46
55 47
56 exports.addonName = {{ basename|json }}; 48 exports.addonName = {{ basename|json }};
57 exports.addonVersion = {{ version|json }}; 49 exports.addonVersion = {{ version|json }};
58 50
59 exports.application = application; 51 exports.application = application;
60 exports.applicationVersion = applicationVersion; 52 exports.applicationVersion = applicationVersion;
61 53
62 exports.platform = platform; 54 exports.platform = "chromium";
63 exports.platformVersion = platformVersion; 55 exports.platformVersion = platformVersion;
OLDNEW
« no previous file with comments | « no previous file | templates/edgeInfo.js.tmpl » ('j') | templates/edgeInfo.js.tmpl » ('J')

Powered by Google App Engine
This is Rietveld