templates/edgeInfo.js.tmpl - Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/edgeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)

Patch Set: fix regexp in edge tmpl, remove platformVersion from chrome tmpl Created June 7, 2017, 4:17 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 /* This Source Code Form is subject to the terms of the Mozilla Public

	2 * License, v. 2.0. If a copy of the MPL was not distributed with this

	3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

	4

	5 "use strict";

	6

	7 let platformVersion = "0";

	8

	9 let match = /\bEdge\/(\S+(?:\.\d+)?)\b/.exec(navigator.userAgent);
	Sebastian Noack 2017/06/08 08:52:30 \S matches any non-whiespace characters, but we re \S matches any non-whiespace characters, but we really just want numbers here. Jon Sonesen 2017/06/08 15:47:28 Done. Show quoted text On 2017/06/08 08:52:30, Sebastian Noack wrote: > \S matches any non-whiespace characters, but we really just want numbers here. Done.
	10 if (match)

	11 platformVersion = match[1];
	Sebastian Noack 2017/06/08 08:52:30 If you assign directly to exports.platformVersion If you assign directly to exports.platformVersion here, we won't need a temporary variable. I don't have a strong opinion which is better, but I'd prefer to remain consistent with how we do it already in other info modules: https://hg.adblockplus.org/buildtools/file/6ab9eb46db2a/templates/geckoInfo.j... Jon Sonesen 2017/06/08 15:47:28 Done. Show quoted text On 2017/06/08 08:52:30, Sebastian Noack wrote: > If you assign directly to exports.platformVersion here, we won't need a > temporary variable. I don't have a strong opinion which is better, but I'd > prefer to remain consistent with how we do it already in other info modules: > https://hg.adblockplus.org/buildtools/file/6ab9eb46db2a/templates/geckoInfo.j... Done.
	12

	13 exports.addonName = {{ basename\|json }};

	14 exports.addonVersion = {{ version\|json }};

	15

	16 exports.application = "edge";

	17 exports.applicationVersion = "0";

	18

	19 exports.platform = "edgehtml"

	20 exports.platformVersion = platformVersion;

OLD	NEW

« no previous file with comments | « templates/chromeInfo.js.tmpl ('k') | templates/modules.js.tmpl » ('j') | no next file with comments »