Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1229)

Issue 29457564: Issue 4917 - Shrink space around accent section headings and content when section contains cards on… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by ire
Modified:
2 years, 1 month ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 4917 - Shrink space around accent section headings and content when section contains cards on acceptableads.com

Patch Set 1 #

Total comments: 5

Patch Set 2 : Apply smaller padding to .group-container selector alone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M static/css/main.css View 1 chunk +7 lines, -0 lines 0 comments Download
M static/scss/components/_groups.scss View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ire
2 years, 1 month ago (2017-06-06 10:05:43 UTC) #1
juliandoucette
Thanks Ire! https://codereview.adblockplus.org/29457564/diff/29457565/static/scss/components/_groups.scss File static/scss/components/_groups.scss (right): https://codereview.adblockplus.org/29457564/diff/29457565/static/scss/components/_groups.scss#newcode27 static/scss/components/_groups.scss:27: .bg-accent .group-container I'm guessing you applied this ...
2 years, 1 month ago (2017-06-08 21:28:54 UTC) #2
ire
https://codereview.adblockplus.org/29457564/diff/29457565/static/scss/components/_groups.scss File static/scss/components/_groups.scss (right): https://codereview.adblockplus.org/29457564/diff/29457565/static/scss/components/_groups.scss#newcode27 static/scss/components/_groups.scss:27: .bg-accent .group-container On 2017/06/08 21:28:54, juliandoucette wrote: > I'm ...
2 years, 1 month ago (2017-06-12 08:39:22 UTC) #3
juliandoucette
LGTM - Please see comment below before pushing. https://codereview.adblockplus.org/29457564/diff/29457565/static/scss/components/_groups.scss File static/scss/components/_groups.scss (right): https://codereview.adblockplus.org/29457564/diff/29457565/static/scss/components/_groups.scss#newcode39 static/scss/components/_groups.scss:39: .bg-accent ...
2 years, 1 month ago (2017-06-16 18:25:30 UTC) #4
ire
2 years, 1 month ago (2017-06-19 09:35:01 UTC) #5
On 2017/06/16 18:25:30, juliandoucette wrote:
> No objections. Please create the issue before marking this Done if you would
> like to do so.

Done - https://issues.adblockplus.org/ticket/5327
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5