Issue 5301 - Edge prepends extension path to URL when using tabs.create

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 683 matching lines @@
     };
   }
   else
   {
     // Edge does not yet support runtime.openOptionsPage (tested version 38)
     // and so this workaround needs to stay for now.
     ext.showOptions = callback =>
     {
       chrome.windows.getLastFocused(win =>
       {
-        let optionsUrl = chrome.extension.getURL("options.html");
+        // NOTE: we expect this else branch to run only on Edge.

[Sebastian Noack, 2017/06/07 12:05:25]

Well, if we should ever merge this upstream it will not only run on Edge. Is
this bug expected to be fixed in MS Edge soon enough in a version we can require
as minimum version? What would happen on Chrome and Firefox, if we use a
relative URL here?

[Oleksandr, 2017/06/07 12:09:29]

From what I understand only Edge does not support
chrome.runtime.openOptionsPage(). Which is why this code is ran only on Edge.
This patch is meant to be submitted to the master branch. There's also only 6
other small patches to make master compatible with Edge.

+        // We are not using extension.getURL here because of the Edge issue:
+        // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
+        let optionsUrl = "options.html";
         let queryInfo = {url: optionsUrl};
 
         // extension pages can't be accessed in incognito windows. In order to
         // correctly mimic the way in which Chrome opens extension options,
         // we have to focus the options page in any other window.
         if (!win.incognito)
           queryInfo.windowId = win.id;
 
         chrome.tabs.query(queryInfo, tabs =>
         {
@@ skipping 20 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());