Issue 5315 - Add support for Microsoft Edge

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 256 matching lines @@
     {
       for (let key in items)
         overrides[keyToPref(key)] = items[key];
 
       resolve();
     });
   });
 
   let managedLoaded = new Promise(resolve =>
   {
-    if (require("info").platform == "chromium" && "managed" in chrome.storage)
+    if (typeof chrome == "object" && "managed" in chrome.storage)

[Sebastian Noack, 2017/06/07 14:42:14]

Won't typeof chrome == "object" always evaluate to true?

[kzar, 2017/06/08 10:50:27]

I thought so too, but maybe we're missing something

Also Ollie, not totally relevant, and you probably already know this, but
`typeof null` is "object", but `null.storage` would result in an exception. Just
mentioning it since I found that surprising in the past.

[Sebastian Noack, 2017/06/08 10:59:19]

Most likely, when this change was intially authored, upstream code still
supported Safari in which case this check would made sense, but not anymore.
I think it it is safe to assume that if "chrome" is defined that it is not null.
Somebody would have to deliberately put "chrome = null" somewhere in the code,
to cause this to happen, which would not only produce failures here.

[kzar, 2017/06/08 11:37:43]

Yea, that's true. Just thought I'd mention it since I found it surprising that
null is considered an object in the past.

[Oleksandr, 2017/06/14 03:41:01]

Yes. This was for issue #3705. It doesn't look like this change is needed
indeed. require("info").platform in Edge is 'edgehtml', and
chrome.storage.managed is undefined. Maybe even the platform check is redundant.

[Sebastian Noack, 2017/06/14 05:13:38]

Yeah, please remove the platform check, so that should Microsoft Edge (or
Firefox), ever support storage.managed in the future, it will just work.

     {
       chrome.storage.managed.get(null, items =>
       {
         // Opera doesn't support chrome.storage.managed, but instead simply
         // removing the API, Opera sets chrome.runtime.lastError when using it.
         // So we have to retrieve that error, to prevent it from showing up
         // in the console.
         chrome.runtime.lastError;
 
         for (let key in items)
@@ skipping 26 matching lines @@
           eventEmitter.emit(pref);
         }
       }
     });
   }
 
   Prefs.untilLoaded = Promise.all([localLoaded, managedLoaded]).then(onLoaded);
 }
 
 init();