Issue 5315 - Add support for Microsoft Edge

README.md

-Adblock Plus for Chrome, Opera and Firefox
+Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox
 ==========================================

[Sebastian Noack, 2017/06/14 05:13:39]

Nit: Please use as many equal signs here as the line above is long. While this
isn't strictly necessary in markdown, it makes it easier to read as plain text.

 
 This repository contains the platform-specific Adblock Plus source code for
-Chrome, Opera and Firefox. It can be used to build Adblock Plus for these
-platforms, generic Adblock Plus code will be extracted from other repositories
-automatically (see _dependencies_ file).
+Chrome, Opera, Microsoft Edge and Firefox. It can be used to build
+Adblock Plus for these platforms, generic Adblock Plus code will be extracted
+from other repositories automatically (see _dependencies_ file).
 
 Note that the Firefox extension built from this repository is the new
 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).
 The source code of the legacy Adblock Plus extension
 can be found [here](https://hg.adblockplus.org/adblockplus).
 
 Building
 ---------
 
 ### Requirements
 
 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (whichever you used to clone this repository)
 - [Python 2.7](https://www.python.org)
 - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8)
 - [The PIL module](http://www.pythonware.com/products/pil/)
 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/)
 
 ### Building the extension
 
 Run one of the following commands in the project directory, depending on your
 target platform:
 
     ./build.py -t chrome build -k adblockpluschrome.pem
     ./build.py -t gecko-webext build
+    ./build.py -t edge build

[Sebastian Noack, 2017/06/14 05:13:39]

Nit: In the human-readable description we refer to Microsoft Edge first, then
Firefox. With the sample commands here and below, Firefox is mentioned first,
then Microsoft Edge. Please make it consistent.

 
 This will create a build with a name in the form
-_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplusfirefox-1.2.3.nnnn.xpi_
+_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplusfirefox-1.2.3.nnnn.xpi_ or

[Sebastian Noack, 2017/06/14 05:13:39]

Nit: Don't use multiple "or", use "a, b or c" instead.

+_adblockplusedge-1.2.3.nnnn.appx_.
 
 Note that you don't need an existing signing key for Chrome, a new key
 will be created automatically if the file doesn't exist.
 
+The Microsoft Edge build _adblockplusedge-1.2.3.nnnn.appx_ is unsigned and
+is only useful for uploading into Windows Store, where it will be signed. For
+testing use the devenv build.
+
 The Firefox extension will be unsigned, and therefore is mostly only useful for
 upload to Mozilla Add-ons. You can also also load it for testing purposes under
 _about:debugging_ or by disabling signature enforcement in Firefox Nightly.
 
 ### Development environment
 
 To simplify the process of testing your changes you can create an unpacked
 development environment. For that run one of the following commands:
 
     ./build.py -t chrome devenv
     ./build.py -t gecko-webext devenv
+    ./build.py -t edge devenv
 
 This will create a _devenv.*_ directory in the repository. You can load the
 directory as an unpacked extension, under _chrome://extensions_ in Chrome,
-or under _about:debugging_ in Firefox. After making changes to the
-source code re-run the command to update the development environment, the
-extension should reload automatically after a few seconds.
+under _about:debugging_ in Firefox or in Extensions menu in Edge, after enabling

[Sebastian Noack, 2017/06/14 05:13:38]

"... in the _Extensions_ menu in Microsoft Edge ..."

+extension development features in _about:flags_. After making changes to the
+source code re-run the command to update the development environment. In Chrome
+and Firefox the extension should reload automatically after a few seconds.
+
+Edge build does not automatically detect changes, so after rebuilding the

[Sebastian Noack, 2017/06/14 05:13:39]

"Builds for Microsoft Edge do not ..."

+extension you should manually force reloading it in Edge by hitting the 
+_Reload Extension_ button.
 
 Running the unit tests
 ----------------------
 
 To verify your changes you can use the unit test suite located in the _qunit_
 directory of the repository. In order to run the unit tests go to the
 extension's Options page, open the JavaScript Console and type in:
 
     location.href = "qunit/index.html";
 
 The unit tests will run automatically once the page loads.
 
 Linting
 -------
 
 You can lint the code using [ESLint](http://eslint.org).
 
     eslint *.js lib/ qunit/ ext/ chrome/
 
 You will need to set up ESLint and our configuration first, see
 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-config-eyeo)
 for more information.