Issue 5315 - Add support for Microsoft Edge

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 599 matching lines @@
   chrome.runtime.onMessage.addListener((message, rawSender, sendResponse) =>
   {
     let sender = {};
 
     // Add "page" and "frame" if the message was sent by a content script.
     // If sent by popup or the background page itself, there is no "tab".
     if ("tab" in rawSender)
     {
       sender.page = new Page(rawSender.tab);
       sender.frame = {
-        url: new URL(rawSender.url),
+        // In Edge requests from internal extension pages
+        // (protocol ms-browser-extension://) do no have a sender URL.
+        url: rawSender.url ? new URL(rawSender.url) : null,
         get parent()
         {
           let frames = framesOfTabs.get(rawSender.tab.id);
 
           if (!frames)
             return null;
 
           let frame = frames.get(rawSender.frameId);
           if (frame)
             return frame.parent || null;
@@ skipping 61 matching lines @@
     };
   }
   else
   {
     // Edge does not yet support runtime.openOptionsPage (tested version 38)
     // and so this workaround needs to stay for now.
     ext.showOptions = callback =>
     {
       chrome.windows.getLastFocused(win =>
       {
-        let optionsUrl = chrome.extension.getURL("options.html");
+        // NOTE: we expect this else branch to run only on Edge.

[kzar, 2017/06/22 11:23:37]

Isn't this comment kind of the same as the one on line 698? If so maybe just add
the details about the Edge issue to that one?

[Oleksandr, 2017/06/22 13:34:59]

Done.

+        // We are not using extension.getURL here because of the Edge issue:
+        // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
+        let optionsUrl = "options.html";
         let queryInfo = {url: optionsUrl};
 
         // extension pages can't be accessed in incognito windows. In order to
         // correctly mimic the way in which Chrome opens extension options,
         // we have to focus the options page in any other window.
         if (!win.incognito)
           queryInfo.windowId = win.id;
 
         chrome.tabs.query(queryInfo, tabs =>
         {
@@ skipping 20 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());