Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: icons/abp-44.png
Issue
29458601
:
Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Address the nits
Created June 22, 2017, 1:32 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Rebase the README.md, compress images, adress the comments
Patch Set 3: Handle webRequest.ResourceType (#5321) and RTCPeerConnection.generateCertificate, address comments
Patch Set 4: Make copyProperties more generic
Patch Set 5: Address the nits
Patch Set 6: Make checks for 'chrome' object existence consistent
Patch Set 7: Future proof in case Edge supports OBJECT request interception
Patch Set 8: Workaround CSS.excape, i18n issue and use typeof for 'undefined' detection
Patch Set 9: Use messaging for CSS escaping
Patch Set 10: Use quoteCSS. Rephrase the comment.
Patch Set 11: Rephrase the comment
Patch Set 12: Rebase to current tip
Patch Set 13: Cosmetic changes
Right:
Patch Set 1: None
Patch Set 2: Rebase the README.md, compress images, adress the comments
Patch Set 3: Handle webRequest.ResourceType (#5321) and RTCPeerConnection.generateCertificate, address comments
Patch Set 4: Make copyProperties more generic
Patch Set 5: Address the nits
Patch Set 6: Make checks for 'chrome' object existence consistent
Patch Set 7: Future proof in case Edge supports OBJECT request interception
Patch Set 8: Workaround CSS.excape, i18n issue and use typeof for 'undefined' detection
Patch Set 9: Use messaging for CSS escaping
Patch Set 10: Use quoteCSS. Rephrase the comment.
Patch Set 11: Rephrase the comment
Patch Set 12: Rebase to current tip
Patch Set 13: Cosmetic changes
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
README.md
ext/background.js
ext/common.js
ext/popup.js
icons/abp-150.png
icons/abp-44.png
icons/abp-50.png
inject.preload.js
lib/csp.js
lib/requestBlocker.js
metadata.edge
View unified diff
|
Download patch
« ext/popup.js
('K') |
« icons/abp-150.png
('k') |
icons/abp-50.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« ext/popup.js
('K') |
« icons/abp-150.png
('k') |
icons/abp-50.png »
('j') |
no next file with comments »
Edit Message
Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Created June 7, 2017, 12:41 p.m. by Oleksandr
Modified July 28, 2017, 4:08 p.m.
Reviewers Sebastian Noack, kzar
Base URL:
Comments: 69
+ 4 drafts
This is Rietveld