metadata.edge - Issue 29458601: Issue 5315 - Add support for Microsoft Edge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.edge

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)

Left Patch Set: Created June 7, 2017, 12:41 p.m.

Right Patch Set: Cosmetic changes Created July 28, 2017, 11:02 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 version = 0.9.10.0	5 version = 0.9.11.0

6 basename = adblockplusedge	6 basename = adblockplusedge

7 app_id_release = EyeoGmbH.AdblockPlus	7 app_id_release = EyeoGmbH.AdblockPlus

8 app_id_devbuild = EyeoGmbH.AdblockPlusdevelopmentbuild	8 app_id_devbuild = EyeoGmbH.AdblockPlusdevelopmentbuild

9 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	9 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

10 background_color = red	10 background_color = red

	11 extension_id_release = 1.0

11	12

12 [compat]	13 [compat]

13 edge = 37.14332.1000.0	14 edge = 40.15063.0.0

14 windows = 10.0.14332.0/12.0.0.0	15 windows = 10.0.15063.0/12.0.0.0
Sebastian Noack 2017/06/07 14:42:14 Does the build number has been updated yet to refl Does the build number has been updated yet to reflect the corresponding minimum version that is actually required to have these combination of changes work? You said, you want to do it differently, but if we squash all of these changes anyway, I guess, we should as well avoid an inconsistent state here. Oleksandr 2017/06/14 03:41:01 Updated the build number. Also extension_id_releas Show quoted text On 2017/06/07 14:42:14, Sebastian Noack wrote: > Does the build number has been updated yet to reflect the corresponding minimum > version that is actually required to have these combination of changes work? You > said, you want to do it differently, but if we squash all of these changes > anyway, I guess, we should as well avoid an inconsistent state here. Updated the build number. Also extension_id_release, as described in #4616.
15	16

16 [appx_assets]	17 [appx_assets]

17 logo_44.png = icons/abp-44.png	18 logo_44.png = icons/abp-44.png

18 logo_50.png = icons/abp-50.png	19 logo_50.png = icons/abp-50.png

19 logo_150.png = icons/abp-150.png	20 logo_150.png = icons/abp-150.png
Sebastian Noack 2017/06/07 14:42:14 Since I cannot comment on binary files, I do so he Since I cannot comment on binary files, I do so here: The file size of these images can be optimized using zopflipng: https://adblockplus.org/coding-style#general The Debian/Ubuntu package is named "zopfli", however, "zopflipng" was just added to the package recently. But you can download the latest package from here and install it with "dpkg -i": http://ftp.debian.org/debian/pool/main/z/zopfli/zopfli_1.0.1+git160527-1_amd6... Oleksandr 2017/06/14 03:41:02 Done. Show quoted text On 2017/06/07 14:42:14, Sebastian Noack wrote: > Since I cannot comment on binary files, I do so here: The file size of these > images can be optimized using zopflipng: > https://adblockplus.org/coding-style#general > > The Debian/Ubuntu package is named "zopfli", however, "zopflipng" was just added > to the package recently. But you can download the latest package from here and > install it with "dpkg -i": > http://ftp.debian.org/debian/pool/main/z/zopfli/zopfli_1.0.1+git160527-1_amd6... Done.
LEFT	RIGHT