Issue 5315 - Add support for Microsoft Edge

inject.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 156 matching lines @@
       dispatchEvent(new RealCustomEvent(eventName,
                                         {detail: {url, requestType}}));
     };
   }
 
   // Only to be called before the page's code, not hardened.
   function copyProperties(src, dest, properties)
   {
     for (let name of properties)
     {
-      Object.defineProperty(dest, name,
-                            Object.getOwnPropertyDescriptor(src, name));
+      if (src.hasOwnProperty(name))
+      {
+        Object.defineProperty(dest, name,
+                              Object.getOwnPropertyDescriptor(src, name));
+      }
     }
   }
 
   /*
    * WebSocket wrapper
    *
    * Required before Chrome 58, since the webRequest API didn't allow us to
    * intercept WebSockets.
    * See https://bugs.chromium.org/p/chromium/issues/detail?id=129353
    */
@@ skipping 179 matching lines @@
       constraints = args[1];
 
     let peerconnection = new RealRTCPeerConnection(configuration, constraints);
     checkConfiguration(peerconnection, configuration);
     return peerconnection;
   }
 
   WrappedRTCPeerConnection.prototype = RealRTCPeerConnection.prototype;
 
   let boundWrappedRTCPeerConnection = WrappedRTCPeerConnection.bind();
-  // NOTE: Edge does not support generateCertificate

[Sebastian Noack, 2017/06/19 11:07:02]

But what is about the other properties copied here?

[kzar, 2017/06/19 14:13:38]

Yea, this is not good. Please instead modify the copyProperties function to
check if the property exists. Something like this (untested):

  function copyProperties(src, dest, properties)
  {
    for (let name of properties)
    {
      if (src.hasOwnProperty(name))
      {
        Object.defineProperty(dest, name,
                              Object.getOwnPropertyDescriptor(src, name));
      }
    }
  }

[Oleksandr, 2017/06/21 23:38:35]

Done.

-  if ("generateCertificate" in RealRTCPeerConnection)
-    copyProperties(RealRTCPeerConnection, boundWrappedRTCPeerConnection,
-                   ["generateCertificate", "name", "prototype"]);
+  copyProperties(RealRTCPeerConnection, boundWrappedRTCPeerConnection,
+                 ["generateCertificate", "name", "prototype"]);
   RealRTCPeerConnection.prototype.constructor = boundWrappedRTCPeerConnection;
 
   if ("RTCPeerConnection" in window)
     window.RTCPeerConnection = boundWrappedRTCPeerConnection;
   if ("webkitRTCPeerConnection" in window)
     window.webkitRTCPeerConnection = boundWrappedRTCPeerConnection;
 }
 
 if (document instanceof HTMLDocument)
 {
   let sandbox = window.frameElement &&
                 window.frameElement.getAttribute("sandbox");
 
   if (typeof sandbox != "string" || /(^|\s)allow-scripts(\s|$)/i.test(sandbox))
   {
     let script = document.createElement("script");
     script.type = "application/javascript";
     script.async = false;
     script.textContent = "(" + injected + ")('" + randomEventName + "');";
     document.documentElement.appendChild(script);
     document.documentElement.removeChild(script);
   }
 }