Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/filterComposer.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Left Patch Set: Use messaging for CSS escaping Created July 17, 2017, 11:49 p.m.
Right Patch Set: Cosmetic changes Created July 28, 2017, 11:02 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/csp.js ('k') | lib/requestBlocker.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 style: message.style, 242 style: message.style,
243 classes: message.classes, 243 classes: message.classes,
244 urls: message.urls, 244 urls: message.urls,
245 type: message.mediatype, 245 type: message.mediatype,
246 baseURL: message.baseURL, 246 baseURL: message.baseURL,
247 page: sender.page, 247 page: sender.page,
248 frame: sender.frame 248 frame: sender.frame
249 }); 249 });
250 }); 250 });
251 251
252 port.on("utils.escapeCSS", (message, sender) => 252 port.on("composer.quoteCSS", (message, sender) =>
kzar 2017/07/18 09:30:50 Wouldn't the message name be composer.quoteCSS?
253 { 253 {
254 return escapeCSS(message.CSS); 254 return quoteCSS(message.CSS);
kzar 2017/07/18 09:30:49 I think Sebastian was suggesting to use quoteCSS.
255 }); 255 });
256 256
257 ext.pages.onLoading.addListener(page => 257 ext.pages.onLoading.addListener(page =>
258 { 258 {
259 page.sendMessage({type: "composer.content.finished"}); 259 page.sendMessage({type: "composer.content.finished"});
260 }); 260 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld