Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/popup.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Created June 7, 2017, 12:41 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ext/popup.js
===================================================================
--- a/ext/popup.js
+++ b/ext/popup.js
@@ -2,6 +2,9 @@
(function()
{
+ if ((typeof chrome == "undefined") ||
+ (typeof chrome.extension == "undefined"))
Sebastian Noack 2017/06/07 14:42:14 Why is explicit checking for chrome.extension nece
Oleksandr 2017/06/14 03:41:01 There is a 'chrome' object defined in Edge, which
Sebastian Noack 2017/06/14 05:13:38 That's why we only check for `typeof chrome.extens
+ chrome = browser;
Sebastian Noack 2017/06/07 14:42:14 Is this variable meant to be global? If so, we sho
Oleksandr 2017/06/14 03:41:01 Done.
const backgroundPage = chrome.extension.getBackgroundPage();
window.ext = Object.create(backgroundPage.ext);

Powered by Google App Engine
This is Rietveld