ext/background.js - Issue 29458601: Issue 5315 - Add support for Microsoft Edge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/background.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)

Patch Set: Handle webRequest.ResourceType (#5321) and RTCPeerConnection.generateCertificate, address comments Created June 15, 2017, 11:18 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/background.js

===================================================================

--- a/ext/background.js

+++ b/ext/background.js

@@ -617,7 +617,9 @@

{

sender.page = new Page(rawSender.tab);

sender.frame = {

- url: new URL(rawSender.url),

+ // In Edge requests from internal extension pages

+ // (protocol ms-browser-extension://) do no have a sender URL.

+ url: rawSender.url ? new URL(rawSender.url) : null,

get parent()

{

let frames = framesOfTabs.get(rawSender.tab.id);

@@ -699,7 +701,10 @@

{

chrome.windows.getLastFocused(win =>

{

- let optionsUrl = chrome.extension.getURL("options.html");

+ // NOTE: we expect this else branch to run only on Edge.

+ // We are not using extension.getURL here because of the Edge issue:

+ // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/

+ let optionsUrl = "options.html";

let queryInfo = {url: optionsUrl};

// extension pages can't be accessed in incognito windows. In order to

« no previous file with comments | « README.md ('k') | ext/common.js » ('j') | ext/common.js » ('J')