Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/popup.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Use messaging for CSS escaping Created July 17, 2017, 11:49 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/common.js ('k') | icons/abp-150.png » ('j') | lib/filterComposer.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/popup.js
===================================================================
--- a/ext/popup.js
+++ b/ext/popup.js
@@ -2,6 +2,8 @@
(function()
{
+ if (typeof chrome == "undefined" || typeof chrome.extension == "undefined")
+ window.chrome = browser;
const backgroundPage = chrome.extension.getBackgroundPage();
window.ext = Object.create(backgroundPage.ext);
@@ -10,6 +12,11 @@
window.close();
};
+ // Calling getMessage with subsitutes on i18n from the background page causes
+ // Edge to throw an exception.
+ // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12793975/
+ window.ext.i18n = chrome.i18n;
+
// We have to override ext.backgroundPage, because in order
// to send messages the local "chrome" namespace must be used.
window.ext.backgroundPage = {
« no previous file with comments | « ext/common.js ('k') | icons/abp-150.png » ('j') | lib/filterComposer.js » ('J')

Powered by Google App Engine
This is Rietveld