Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29458622: Issue 4920 - Add "Ready for Windows" section to adblockplus.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Create notice class, use conditional rule Created June 19, 2017, 9:52 a.m.
Right Patch Set: Style fixes Created June 21, 2017, 8:29 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/index.tmpl ('k') | static/css/index-mobile.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #content h1, #content h2 1 #content h1, #content h2
2 { 2 {
3 font-size: 16px; 3 font-size: 16px;
4 } 4 }
5 5
6 #content .sprite 6 #content .sprite
7 { 7 {
8 background-image: url(../img/sprite-index.png); 8 background-image: url(../img/sprite-index.png);
9 } 9 }
10 10
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 #more-container.android #more-android, 700 #more-container.android #more-android,
701 #more-container.internet-explorer #more-internet-explorer, 701 #more-container.internet-explorer #more-internet-explorer,
702 #more-container.safari #more-safari, 702 #more-container.safari #more-safari,
703 #more-container.yandex-browser #more-yandex-browser, 703 #more-container.yandex-browser #more-yandex-browser,
704 #more-container.maxthon #more-maxthon 704 #more-container.maxthon #more-maxthon
705 #more-container.edge #more-edge 705 #more-container.edge #more-edge
706 { 706 {
707 background-color: #dbd4c7; 707 background-color: #dbd4c7;
708 } 708 }
709 709
710 .notice { 710 .notice
juliandoucette 2017/06/20 16:20:16 "Opening braces always go on their own line." --
ire 2017/06/21 08:30:18 Acknowledged.
711 background-color: #ffffff; 711 {
juliandoucette 2017/06/20 16:20:17 "CSS rule declaration order should follow the Word
ire 2017/06/21 08:30:18 Acknowledged.
712 padding: 20px; 712 padding: 20px;
713 line-height: 1.4;
714 color: #000;
715 background-color: #fff;
713 border: 2px solid #a1a1a1; 716 border: 2px solid #a1a1a1;
714 box-sizing: border-box; 717 }
juliandoucette 2017/06/20 16:20:17 What difference does this make?
ire 2017/06/21 08:30:18 I had previously had `width: 100%` on this element
715 color: #000000; 718
juliandoucette 2017/06/20 16:20:16 "Use 3 character hexadecimal notation where possib
ire 2017/06/21 08:30:18 Acknowledged.
716 } 719 #ready-for-windows-notice
717 720 {
718 #ready-for-windows-notice { 721 margin-bottom: 30px;
719 margin: 10px 10px 30px; 722 }
juliandoucette 2017/06/20 16:20:17 Why should only this notice be less wide and have
ire 2017/06/21 08:30:18 It isn't meant to be. I had incorrectly copied the
720 line-height: 1.4;
juliandoucette 2017/06/20 16:20:17 Why should only this notice have comfortable line
ire 2017/06/21 08:30:18 I will move this style to the .notice class
721 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld