update-copyright/tests/data/sample_file.py - Issue 29459580: Issue 5250 - Add copyright update script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: update-copyright/tests/data/sample_file.py

Issue 29459580: Issue 5250 - Add copyright update script (Closed) Base URL: https://hg.adblockplus.org/codingtools

Patch Set: Minor formatting fixes Created July 4, 2017, 3:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 # This file is part of the Adblock Plus web scripts,

	2 # Copyright (C) 2006-2015 eyeo GmbH

	3 #

	4 # Adblock Plus is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License version 3 as

	6 # published by the Free Software Foundation.

	7 #

	8

	9

	10 def foo():

	11 return 1

	12

	13 # Copyright (C) 2006-2014 eyeo GmbH
	Sebastian Noack 2017/07/05 15:46:53 Perhaps we should also test for copyright informat Perhaps we should also test for copyright information in strings (not only in comments). This is actually a real use case which we have in adblockplusie. Also I think we should test that non-eyeo copyright information are left alone. There are more cases covered by the logic implemented, which we could address with the tests, but we have the above two cases in our actual code, and therefore it might be worth to cover them at least. rosie 2017/07/07 15:55:48 Done. Show quoted text On 2017/07/05 15:46:53, Sebastian Noack wrote: > Perhaps we should also test for copyright information in strings (not only in > comments). This is actually a real use case which we have in adblockplusie. > Also I think we should test that non-eyeo copyright information are left alone. > > There are more cases covered by the logic implemented, which we could address > with the tests, but we have the above two cases in our actual code, and > therefore it might be worth to cover them at least. Done.
OLD	NEW