Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Unified Diff: mobile/android/base/widget/ContentSecurityDoorHanger.java

Issue 29459615: Issue 5194 - Remove Tracking Protection from Private Browsing (Closed)
Patch Set: Removing tracking link Created June 12, 2017, 12:24 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mobile/android/base/BrowserApp.java ('k') | mobile/android/chrome/content/aboutPrivateBrowsing.xhtml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mobile/android/base/widget/ContentSecurityDoorHanger.java
===================================================================
--- a/mobile/android/base/widget/ContentSecurityDoorHanger.java
+++ b/mobile/android/base/widget/ContentSecurityDoorHanger.java
@@ -68,17 +68,19 @@ public class ContentSecurityDoorHanger e
try {
final String linkLabel = link.getString("label");
final String linkUrl = link.getString("url");
addLink(linkLabel, linkUrl);
} catch (JSONException e) { }
}
final JSONObject trackingProtection = options.optJSONObject("tracking_protection");
- if (trackingProtection != null) {
+ // We don't want to show the tracking protection hanger.
+ // See https://issues.adblockplus.org/ticket/5194
+ if (false) {
mTitle.setVisibility(VISIBLE);
mTitle.setText(R.string.doorhanger_tracking_title);
try {
final boolean enabled = trackingProtection.getBoolean("enabled");
if (enabled) {
mMessage.setText(R.string.doorhanger_tracking_message_enabled);
mSecurityState.setText(R.string.doorhanger_tracking_state_enabled);
mSecurityState.setTextColor(ColorUtils.getColor(getContext(), R.color.affirmative_green));
« no previous file with comments | « mobile/android/base/BrowserApp.java ('k') | mobile/android/chrome/content/aboutPrivateBrowsing.xhtml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld